Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Blocks: Fix demo teaser markup, More block custom text #2828
This pull request seeks to resolve two issues with the More block:
Verify that when viewing the demo, the more block is shown with custom "Keep on reading!" text, that selecting the More block reveals "Teaser" is checked in the block settings, and that no freeform block is shown following the More block. Check that setting custom text to the More block, saving and reloading respects the changes made.
@@ Coverage Diff @@ ## master #2828 +/- ## ========================================== + Coverage 33.78% 33.79% +0.01% ========================================== Files 191 191 Lines 5692 5693 +1 Branches 997 998 +1 ========================================== + Hits 1923 1924 +1 Misses 3189 3189 Partials 580 580
Hm, yes, I can confirm this too. One half of this issue (not being serialized correctly) is fixed in 3a45620 .
But also, the "Null" text being shown stems from the fact that the PEG parser returns
Where this becomes more interesting is in how we align this with the PHP attributes behavior, where PHP only has the single concept of