New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code in BlockList component #2848

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Oct 2, 2017

Just removing some dead code

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 2, 2017

Codecov Report

Merging #2848 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   33.74%   33.77%   +0.02%     
==========================================
  Files         191      191              
  Lines        5695     5691       -4     
  Branches      997      996       -1     
==========================================
  Hits         1922     1922              
+ Misses       3192     3189       -3     
+ Partials      581      580       -1
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a596ceb...e2c6e6d. Read the comment docs.

codecov bot commented Oct 2, 2017

Codecov Report

Merging #2848 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   33.74%   33.77%   +0.02%     
==========================================
  Files         191      191              
  Lines        5695     5691       -4     
  Branches      997      996       -1     
==========================================
  Hits         1922     1922              
+ Misses       3192     3189       -3     
+ Partials      581      580       -1
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a596ceb...e2c6e6d. Read the comment docs.

@gziolo

gziolo approved these changes Oct 2, 2017

LGTM :shipit:

@youknowriad youknowriad merged commit efd262d into master Oct 2, 2017

3 checks passed

codecov/project 33.77% (+0.02%) compared to a596ceb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/remove-dead-code branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment