New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a feedback link to the Gutenberg menu #2850

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
4 participants
@youknowriad
Contributor

youknowriad commented Oct 2, 2017

fix #2802

AFAIK, There's no easy way to add an external link with a target _blank to a WordPress admin menu, We'd need to add all sorts of "hacks" to do this. This PR adds a simple link instead.

@youknowriad youknowriad requested a review from karmatosed Oct 2, 2017

@youknowriad youknowriad self-assigned this Oct 2, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 2, 2017

Codecov Report

Merging #2850 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage   33.77%   33.43%   -0.35%     
==========================================
  Files         191      191              
  Lines        5691     5749      +58     
  Branches      996     1009      +13     
==========================================
  Hits         1922     1922              
- Misses       3189     3234      +45     
- Partials      580      593      +13
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd262d...92c3bfd. Read the comment docs.

codecov bot commented Oct 2, 2017

Codecov Report

Merging #2850 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage   33.77%   33.43%   -0.35%     
==========================================
  Files         191      191              
  Lines        5691     5749      +58     
  Branches      996     1009      +13     
==========================================
  Hits         1922     1922              
- Misses       3189     3234      +45     
- Partials      580      593      +13
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd262d...92c3bfd. Read the comment docs.

@gziolo

gziolo approved these changes Oct 2, 2017 edited

I can see the link:

screen shot 2017-10-02 at 12 13 59

I can access the poll:

screen shot 2017-10-02 at 12 14 06

I'm not sure it that is a preferred WP solution, but it obviously works 🚢

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Oct 2, 2017

Contributor

We don't need _blank.

Contributor

mtias commented Oct 2, 2017

We don't need _blank.

@karmatosed

There seems to be no better option than feedback so lets leave it called that and merge :)

@youknowriad youknowriad merged commit 6520235 into master Oct 2, 2017

3 checks passed

codecov/project 33.43% (-0.35%) compared to efd262d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the add/feedback-link branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment