New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Update Jest and partially React with MIT licensed version #2866

Merged
merged 3 commits into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Oct 3, 2017

Checklist:

  • Upgrade to the stable version of React
  • Upgrade Jest (MIT license)

This tries to land part of the #2813 as we are still having trouble integrating the latest Enzyme version with our tests. We want to start using the latest version of React on the frontend to catch the potential issues before we find a way to make all failing tests work with new React 16 Enzyme adapter.

@gziolo gziolo self-assigned this Oct 3, 2017

@gziolo gziolo requested a review from youknowriad Oct 3, 2017

@gziolo gziolo changed the title from Update/jest deps to Framework: Update Jest and partially React with MIT licensed version Oct 3, 2017

"eslint-plugin-jsx-a11y": "4.0.0",
"eslint-plugin-react": "6.10.3",
"expose-loader": "0.7.3",
"extract-text-webpack-plugin": "3.0.0",
"gettext-parser": "1.3.0",
"jest": "20.0.4",
"jest-junit-reporter": "1.1.0",

This comment has been minimized.

@gziolo

gziolo Oct 3, 2017

Member

We don't use it at all.

@gziolo

gziolo Oct 3, 2017

Member

We don't use it at all.

This comment has been minimized.

@youknowriad

youknowriad Oct 3, 2017

Contributor

In my testing, it was being required as an enzyme peer dependency

@youknowriad

youknowriad Oct 3, 2017

Contributor

In my testing, it was being required as an enzyme peer dependency

This comment has been minimized.

@gziolo

gziolo Oct 3, 2017

Member

That's strange, I think I added it because we have that in Calypso to integrate with CircleCI.

@gziolo

gziolo Oct 3, 2017

Member

That's strange, I think I added it because we have that in Calypso to integrate with CircleCI.

This comment has been minimized.

@gziolo

gziolo Oct 3, 2017

Member

Yes, it was me with 1406fe8.

@gziolo

gziolo Oct 3, 2017

Member

Yes, it was me with 1406fe8.

This comment has been minimized.

@youknowriad

youknowriad Oct 3, 2017

Contributor

Yes, but when upgrading to enzyme3, I dropped it and I had to add it again because it was a peer dependency. Maybe not with the current version of enzyme though

@youknowriad

youknowriad Oct 3, 2017

Contributor

Yes, but when upgrading to enzyme3, I dropped it and I had to add it again because it was a peer dependency. Maybe not with the current version of enzyme though

@@ -51,6 +51,7 @@
"autoprefixer": "6.7.7",
"babel-core": "6.26.0",
"babel-eslint": "7.2.3",
"babel-jest": "21.2.0",

This comment has been minimized.

@gziolo

gziolo Oct 3, 2017

Member

Eslint complains now that it should be added explicitly.

@gziolo

gziolo Oct 3, 2017

Member

Eslint complains now that it should be added explicitly.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 3, 2017

Codecov Report

Merging #2866 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage    33.9%   34.97%   +1.07%     
==========================================
  Files         191      191              
  Lines        5699     5801     +102     
  Branches      999     1034      +35     
==========================================
+ Hits         1932     2029      +97     
- Misses       3187     3189       +2     
- Partials      580      583       +3
Impacted Files Coverage Δ
editor/reducer.js 91.49% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8908351...0ee6a01. Read the comment docs.

codecov bot commented Oct 3, 2017

Codecov Report

Merging #2866 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage    33.9%   34.97%   +1.07%     
==========================================
  Files         191      191              
  Lines        5699     5801     +102     
  Branches      999     1034      +35     
==========================================
+ Hits         1932     2029      +97     
- Misses       3187     3189       +2     
- Partials      580      583       +3
Impacted Files Coverage Δ
editor/reducer.js 91.49% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8908351...0ee6a01. Read the comment docs.

@youknowriad

🚢

@gziolo gziolo merged commit 0ab6abd into master Oct 4, 2017

3 checks passed

codecov/project 34.97% (+1.07%) compared to 8908351
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gziolo gziolo deleted the update/jest-deps branch Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment