New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Fix sidebar scroll overflow (Edge, Safari) #2868

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Oct 3, 2017

Fixes #1899

This pull request seeks to resolve a scroll overflow which occurs in some browsers in the sidebar due to panel styling. The panel uses negative margins to prevent doubling up on borders between panels. This works well for margin-top but in the case of margin-bottom: -1px, it can result in container overflow (scroll). The changes here refactor to eliminate the double border by assigning a border-bottom-width on the last child of the panel, in place of the negative margin.

Before After
Before After

Testing instructions:

Verify that a border is still shown at the bottom of the sidebar Discussion panel (collapsed and expanded), that the border is not doubled up, and that no scroll overflow exists in your preferred browser, Safari, or Edge (Windows).

In macOS, scrollbars are not visible by default unless scrolling. You can change this setting to always show scrollbars in System Preferences > General (and I might recommend keeping the setting this way if you work with CSS frequently).

@aduth aduth added the Chrome label Oct 3, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 3, 2017

Codecov Report

Merging #2868 into master will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2868      +/-   ##
==========================================
+ Coverage    33.9%   34.96%   +1.06%     
==========================================
  Files         191      191              
  Lines        5699     5803     +104     
  Branches      999     1034      +35     
==========================================
+ Hits         1932     2029      +97     
- Misses       3187     3191       +4     
- Partials      580      583       +3
Impacted Files Coverage Δ
...ditor/sidebar/block-inspector/advanced-controls.js 0% <0%> (ø) ⬆️
editor/reducer.js 91.49% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8908351...8550a83. Read the comment docs.

codecov bot commented Oct 3, 2017

Codecov Report

Merging #2868 into master will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2868      +/-   ##
==========================================
+ Coverage    33.9%   34.96%   +1.06%     
==========================================
  Files         191      191              
  Lines        5699     5803     +104     
  Branches      999     1034      +35     
==========================================
+ Hits         1932     2029      +97     
- Misses       3187     3191       +4     
- Partials      580      583       +3
Impacted Files Coverage Δ
...ditor/sidebar/block-inspector/advanced-controls.js 0% <0%> (ø) ⬆️
editor/reducer.js 91.49% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8908351...8550a83. Read the comment docs.

@youknowriad

I would have sworn, we already fixed this. 👍

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Oct 3, 2017

Member

I would have sworn, we already fixed this. 👍

There have been many many overflow issues, hence my plea for contributors to keep macOS scrollbars always visible 😛

Member

aduth commented Oct 3, 2017

I would have sworn, we already fixed this. 👍

There have been many many overflow issues, hence my plea for contributors to keep macOS scrollbars always visible 😛

@aduth aduth merged commit 8df6fb8 into master Oct 3, 2017

3 checks passed

codecov/project 34.96% (+1.06%) compared to 8908351
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aduth aduth deleted the fix/1899-safari-sidebar-overflow branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment