Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Sidebar: Fix sidebar scroll overflow (Edge, Safari) #2868
This pull request seeks to resolve a scroll overflow which occurs in some browsers in the sidebar due to panel styling. The panel uses negative margins to prevent doubling up on borders between panels. This works well for
Verify that a border is still shown at the bottom of the sidebar Discussion panel (collapsed and expanded), that the border is not doubled up, and that no scroll overflow exists in your preferred browser, Safari, or Edge (Windows).
In macOS, scrollbars are not visible by default unless scrolling. You can change this setting to always show scrollbars in System Preferences > General (and I might recommend keeping the setting this way if you work with CSS frequently).
@@ Coverage Diff @@ ## master #2868 +/- ## ========================================== + Coverage 33.9% 34.96% +1.06% ========================================== Files 191 191 Lines 5699 5803 +104 Branches 999 1034 +35 ========================================== + Hits 1932 2029 +97 - Misses 3187 3191 +4 - Partials 580 583 +3