New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URL input actually a plain text input. #732 #2870

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@tfrommen
Contributor

tfrommen commented Oct 4, 2017

Description

The URL input, defined as type="url", does only allow valid URLs, not (partial) URIs. In order to create links to things like anchors, the field is now defined as a plain text input (i.e., without any browser validation).

How Has This Been Tested?

Code it, build it, use it. 馃檪

Screenshots (jpeg or gifs if applicable):

url-input

Types of changes

  • Change the type of the URL input field.
  • Adapt the according CSS rule.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
@aduth

aduth approved these changes Oct 4, 2017

Change makes sense and works well for me 馃憤

@aduth aduth merged commit b7f61d2 into WordPress:master Oct 4, 2017

2 checks passed

codecov/project 33.95% remains the same compared to 0ab6abd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Oct 10, 2017

Contributor

Thanks for this change!

Contributor

mtias commented Oct 10, 2017

Thanks for this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment