Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Blocks: Introduce block settings menu toggle #2884
@@ Coverage Diff @@ ## master #2884 +/- ## ========================================== - Coverage 34.06% 33.82% -0.24% ========================================== Files 192 193 +1 Lines 5677 5729 +52 Branches 997 1008 +11 ========================================== + Hits 1934 1938 +4 - Misses 3166 3203 +37 - Partials 577 588 +11
Visually I love this, I think it's worth trying.
Accessibility wise, it seems like there are sometimes two tab stops between items in the toolbar for me. This is probably an issue separate to the ellipsis menu, but figured I'd mention it.
I pushed a fix to the placement of a few things.
One thing — can we do it so clicking the ellipsis menu also selects the block? Right now if you only hover over the block, click the ellipsis menu, and move the cursor away from the block, the ellipsis menu collapses, making it fiddly to use.
I've noticed this as well. Thought it might have been something with #2323 shifting focus into popover (tooltips are implemented as popovers), but this is meant to have been fixed with #2771 (including for Tooltip, not just AutoComplete).
referenced this pull request
Oct 9, 2017
I still need to test it, but it looks very good. I had only nitpicks, which aren't blockers/