New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/2903 audio block markup #2921

Merged
merged 3 commits into from Oct 9, 2017

Conversation

Projects
None yet
2 participants
@Soean
Member

Soean commented Oct 8, 2017

Description

  • Changes Audio block wrapper from div to figure.
  • Adds caption support for Audio

This PR resolves #2903

How Has This Been Tested?

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • [ x ] My code is tested.
  • [ x ] My code follows the WordPress code style.
  • [ x ] My code follows has proper inline documentation.
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 8, 2017

Codecov Report

Merging #2921 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
- Coverage   34.07%   34.05%   -0.03%     
==========================================
  Files         192      192              
  Lines        5675     5679       +4     
  Branches      996      997       +1     
==========================================
  Hits         1934     1934              
- Misses       3165     3168       +3     
- Partials      576      577       +1
Impacted Files Coverage Δ
blocks/library/audio/index.js 12.12% <33.33%> (-0.79%) ⬇️
blocks/library/gallery/block.js 11.11% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cd1f5...317c4df. Read the comment docs.

codecov bot commented Oct 8, 2017

Codecov Report

Merging #2921 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
- Coverage   34.07%   34.05%   -0.03%     
==========================================
  Files         192      192              
  Lines        5675     5679       +4     
  Branches      996      997       +1     
==========================================
  Hits         1934     1934              
- Misses       3165     3168       +3     
- Partials      576      577       +1
Impacted Files Coverage Δ
blocks/library/audio/index.js 12.12% <33.33%> (-0.79%) ⬇️
blocks/library/gallery/block.js 11.11% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cd1f5...317c4df. Read the comment docs.

@youknowriad

Works great! Just noting this will create the "content updated externally" warning but I think it's ok at the moment.

Left some minor comments if you don't mind fixing. Thanks

Show outdated Hide outdated blocks/library/audio/index.js
Show outdated Hide outdated blocks/test/fixtures/core__audio.json
@Soean

This comment has been minimized.

Show comment
Hide comment
@Soean

Soean Oct 9, 2017

Member

@youknowriad Thanks for your review, I fixed your comments.

Member

Soean commented Oct 9, 2017

@youknowriad Thanks for your review, I fixed your comments.

@youknowriad

Awesome thanks

@youknowriad youknowriad merged commit 64a2b57 into WordPress:master Oct 9, 2017

2 checks passed

codecov/project 34.05% (-0.03%) compared to 27cd1f5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment