Query title block - Archive Title #29428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
New Block
ntsekouras
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
ntsekouras
commented
Mar 1, 2021
packages/e2e-tests/fixtures/blocks/core__table-of-contents.json
Outdated
Show resolved
Hide resolved
|
Size Change: +462 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
This seems to work well in my testing! I created an archive page template, added this block to the template, and it's showing up as expected on the front end. 👍 Editor:
Front End:
|
carolinan
reviewed
Mar 5, 2021
|
I think that we need to match the title and description - I mean that if it is decided that the term/category/tag description block is not a block for the query, but stand-alone, then the title needs to be the same, and their block names should match too. |
|
|
Once I started testing the block I still found it confusing that I could place the block anywhere in the editor, but on the front it only displayed on archive pages. I am struggling with how a user can understand how this block works if it is not a child block of the query, because the editor and front will not match. Can there be a warning instead of a placeholder, on pages that are not archives? For example in the regular post editor. |
Ideally, FSE blocks will only be available in the site-editor. I think I've seen a ticket for that somewhere but can't find it right now... AFAIK that is the plan and these blocks will not be available in the post-editor. |
I understand what you're saying but this is a more complex problem with context detection that hasn't been solved yet. So I agree with you and Ari about:
but this will be handled later.. For now we can probably have a better description to indicate its behavior and I have no strong opinion on making it available only in |
I think it is the opposite, but it is not decided which blocks yet: |
ntsekouras
force-pushed
the
add/query-title-block
branch
2 times, most recently
from
a2f17c2
to
1b49271
Compare
aristath
approved these changes
Mar 11, 2021
Co-authored-by: Carolina Nymark <myazalea@hotmail.com>
ntsekouras
force-pushed
the
add/query-title-block
branch
from
0c95cf3
to
6cc9333
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #22724
This PR adds
Query Titleblock and is implemented withblock variations.It's part of #27989 which will need more decisions about handling
text replacementsfor example inSearch Title(see more info in the above PR's description).For now it only supports
Archive Titlewhich is definitely needed and we can move towards other variations incrementally.Notes about Archive Title
get_the_archive_titlehook