Fix navigation editor block toolbar not visible on small screens #29967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
tellthemachines
as code owners
|
Size Change: +230 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
The code looks good and it works well. Just a minor concern - shouldn't the ellipsis menu be placed in a rightmost corner (cc. @shaunandrews )? like this: |
gwwar
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
@talldan code changes look reasonable 👍 I'll go ahead and give tentative approval here.
I'm documenting a few things I see while testing. These can be fixed in follow ups. Not sure if there are already issues for these. I can follow up on creating new ones if these weren't documented yet.
| Sidebar is open in phone sizes | Select mode can be on top of block toolbar, has drag handles |
|---|---|
 |
 |
Sometimes navigation block editor won't render until mousescroll event:
loadsafterscroll.mp4
talldan
force-pushed
the
fix/nav-editor-missing-block-toolbar-on-small-screens
branch
from
c600ee6
to
22046b5
Compare
@grzim Interesting, I hadn't considered that. I was following this screenshot posted in slack, but it doesn't show the Ellipsis. If the toolbar has to be scrollable then I'd probably expect it not to be aligned right. I expect it to look a bit better after #29100.
@gwwar Good catch, I've fixed the overlapping in this branch. The fixed block toolbar will now hide when in nav mode.
I haven't encountered that one. It'd be good to test in trunk once this is merged. I did encounter an issue where resizing the editor would cause everything to jump down the screen and then back up again at a particular breakpoint. It looks similar. My issue seems to have been fixed by #30013 though, so hopefully it fixes your bug too. |
talldan
deleted the
fix/nav-editor-missing-block-toolbar-on-small-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28875
Implements the 'fixed' version of the block toolbar that's available on smaller screen sizes.
The styling for this isn't perfect, but I'd expect it to improve as part of #29100, when the screen has proper responsive styles.
Working on this was far more complicated than it should really have to be, so I've made a separate issue with some thoughts about block toolbars - #29965
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: