Try: Add site icon and name to the publish flow #30231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to make it clearer where you are publishing to in the final step check.
mtias
commented
Mar 25, 2021
| @@ -50,6 +98,13 @@ function PostPublishPanelPrepublish( { | |||
| <strong>{ prePublishTitle }</strong> | |||
| </div> | |||
| <p>{ prePublishBodyText }</p> | |||
| <div className="components-site-card"> | |||
There was a problem hiding this comment.
We should turn this into a self contained component or components (site icon, site title)
|
Size Change: +631 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Nice. I pushed some polish:
|
mtias
added
General Interface
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to improve the clarity of the "are you ready to publish" by including the site icon and name so that it's clear in certain cases where are you publishing to (full-screen, mobile web, etc).