Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block Library - Post Featured Image]: Add basic dimension controls #31634

Merged
merged 8 commits into from
Jul 30, 2021

Conversation

ntsekouras
Copy link
Contributor

Description

Resolves: #27620

This PR enables basic dimension controls (width, height) and allow object-fit properties to be configured.
I believe landing at least a basic handling for now like this would be okay for now and gives value, in order to make it to 5.8.

Notes

  1. The scale control from the design does not exists now, so I've added some adhoc styles. We might improve those styles or consider adding a new component to match the design.
  2. In order to set some object-fit properties we need to have set both width and height (see comment).
  3. In scale control I've implemented toggle/unset functionality. We can keep this or add a reset/clear button.
  4. height in percentage (%) feels a bit unintuitive IMO - any suggestions?

Testing instructions

  1. Insert Post Featured Image block (single or in a Query block) and set width, height and scale. What feels natural to me is having width in % and height in px, but this is just subjective.
  2. Observe editor and front-end changes.

@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library [Block] Post Featured Image Affects the Post Featured Image Block labels May 9, 2021
@ntsekouras ntsekouras requested review from mtias, jameskoster, kjellr, jasmussen and a team May 9, 2021 09:22
@ntsekouras ntsekouras requested a review from ajitbohra as a code owner May 9, 2021 09:22
@ntsekouras ntsekouras self-assigned this May 9, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

Size Change: +533 B (0%)

Total Size: 1.07 MB

Filename Size Change
build/a11y/index.min.js 1.11 kB -2 B (0%)
build/annotations/index.min.js 2.93 kB -1 B (0%)
build/block-directory/index.min.js 6.61 kB -1 B (0%)
build/block-library/blocks/file/view.min.js 711 B -69 B (-9%)
build/block-library/blocks/navigation/view.min.js 2.84 kB -30 B (-1%)
build/block-library/blocks/post-featured-image/editor-rtl.css 412 B +74 B (+22%) 🚨
build/block-library/blocks/post-featured-image/editor.css 412 B +74 B (+22%) 🚨
build/block-library/blocks/post-featured-image/style-rtl.css 144 B +3 B (+2%)
build/block-library/blocks/post-featured-image/style.css 143 B +2 B (+1%)
build/block-library/editor-rtl.css 9.85 kB +33 B (0%)
build/block-library/editor.css 9.84 kB +34 B (0%)
build/block-library/index.min.js 147 kB +385 B (0%)
build/block-library/style-rtl.css 10.3 kB +3 B (0%)
build/block-library/style.css 10.3 kB +3 B (0%)
build/components/index.min.js 196 kB +13 B (0%)
build/compose/index.min.js 10.2 kB +1 B (0%)
build/core-data/index.min.js 12.4 kB +1 B (0%)
build/data-controls/index.min.js 830 B +1 B (0%)
build/date/index.min.js 31.8 kB +2 B (0%)
build/deprecated/index.min.js 737 B -1 B (0%)
build/edit-navigation/index.min.js 13.9 kB +2 B (0%)
build/edit-post/index.min.js 59.5 kB +4 B (0%)
build/edit-site/index.min.js 25.9 kB -1 B (0%)
build/edit-widgets/index.min.js 16.2 kB +4 B (0%)
build/editor/index.min.js 38.7 kB +11 B (0%)
build/format-library/index.min.js 5.71 kB -1 B (0%)
build/hooks/index.min.js 1.76 kB -1 B (0%)
build/i18n/index.min.js 3.73 kB -2 B (0%)
build/media-utils/index.min.js 3.08 kB -1 B (0%)
build/nux/index.min.js 2.31 kB +1 B (0%)
build/priority-queue/index.min.js 790 B -1 B (0%)
build/rich-text/index.min.js 10.8 kB +1 B (0%)
build/shortcode/index.min.js 1.68 kB -1 B (0%)
build/warning/index.min.js 1.16 kB -5 B (0%)
build/widgets/index.min.js 6.48 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
build/admin-manifest/index.min.js 1.41 kB
build/api-fetch/index.min.js 2.44 kB
build/autop/index.min.js 2.28 kB
build/blob/index.min.js 673 B
build/block-directory/style-rtl.css 1.02 kB
build/block-directory/style.css 1.02 kB
build/block-editor/index.min.js 126 kB
build/block-editor/style-rtl.css 14 kB
build/block-editor/style.css 14 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 112 B
build/block-library/blocks/audio/style.css 112 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 475 B
build/block-library/blocks/button/editor.css 474 B
build/block-library/blocks/button/style-rtl.css 603 B
build/block-library/blocks/button/style.css 602 B
build/block-library/blocks/buttons/editor-rtl.css 315 B
build/block-library/blocks/buttons/editor.css 315 B
build/block-library/blocks/buttons/style-rtl.css 375 B
build/block-library/blocks/buttons/style.css 375 B
build/block-library/blocks/calendar/style-rtl.css 208 B
build/block-library/blocks/calendar/style.css 208 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/columns/editor-rtl.css 190 B
build/block-library/blocks/columns/editor.css 190 B
build/block-library/blocks/columns/style-rtl.css 475 B
build/block-library/blocks/columns/style.css 476 B
build/block-library/blocks/cover/editor-rtl.css 670 B
build/block-library/blocks/cover/editor.css 670 B
build/block-library/blocks/cover/style-rtl.css 1.22 kB
build/block-library/blocks/cover/style.css 1.23 kB
build/block-library/blocks/embed/editor-rtl.css 486 B
build/block-library/blocks/embed/editor.css 486 B
build/block-library/blocks/embed/style-rtl.css 401 B
build/block-library/blocks/embed/style.css 400 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 301 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 704 B
build/block-library/blocks/gallery/editor.css 705 B
build/block-library/blocks/gallery/style-rtl.css 1.06 kB
build/block-library/blocks/gallery/style.css 1.06 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 160 B
build/block-library/blocks/group/editor.css 160 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 93 B
build/block-library/blocks/group/theme.css 93 B
build/block-library/blocks/heading/editor-rtl.css 152 B
build/block-library/blocks/heading/editor.css 152 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/html/editor-rtl.css 281 B
build/block-library/blocks/html/editor.css 281 B
build/block-library/blocks/image/editor-rtl.css 729 B
build/block-library/blocks/image/editor.css 727 B
build/block-library/blocks/image/style-rtl.css 481 B
build/block-library/blocks/image/style.css 485 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 286 B
build/block-library/blocks/latest-comments/style.css 286 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 526 B
build/block-library/blocks/latest-posts/style.css 524 B
build/block-library/blocks/list/style-rtl.css 63 B
build/block-library/blocks/list/style.css 63 B
build/block-library/blocks/media-text/editor-rtl.css 263 B
build/block-library/blocks/media-text/editor.css 264 B
build/block-library/blocks/media-text/style-rtl.css 492 B
build/block-library/blocks/media-text/style.css 489 B
build/block-library/blocks/more/editor-rtl.css 434 B
build/block-library/blocks/more/editor.css 434 B
build/block-library/blocks/navigation-link/editor-rtl.css 474 B
build/block-library/blocks/navigation-link/editor.css 473 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation/editor-rtl.css 1.69 kB
build/block-library/blocks/navigation/editor.css 1.69 kB
build/block-library/blocks/navigation/style-rtl.css 1.65 kB
build/block-library/blocks/navigation/style.css 1.66 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 310 B
build/block-library/blocks/page-list/editor.css 311 B
build/block-library/blocks/page-list/style-rtl.css 240 B
build/block-library/blocks/page-list/style.css 240 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 247 B
build/block-library/blocks/paragraph/style.css 248 B
build/block-library/blocks/post-author/editor-rtl.css 209 B
build/block-library/blocks/post-author/editor.css 209 B
build/block-library/blocks/post-author/style-rtl.css 183 B
build/block-library/blocks/post-author/style.css 184 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B
build/block-library/blocks/post-comments-form/style.css 140 B
build/block-library/blocks/post-comments/style-rtl.css 360 B
build/block-library/blocks/post-comments/style.css 359 B
build/block-library/blocks/post-content/editor-rtl.css 139 B
build/block-library/blocks/post-content/editor.css 139 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-template/editor-rtl.css 100 B
build/block-library/blocks/post-template/editor.css 99 B
build/block-library/blocks/post-template/style-rtl.css 379 B
build/block-library/blocks/post-template/style.css 380 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B
build/block-library/blocks/pullquote/editor.css 183 B
build/block-library/blocks/pullquote/style-rtl.css 318 B
build/block-library/blocks/pullquote/style.css 318 B
build/block-library/blocks/pullquote/theme-rtl.css 169 B
build/block-library/blocks/pullquote/theme.css 169 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B
build/block-library/blocks/query-pagination/editor.css 262 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B
build/block-library/blocks/query-pagination/style.css 168 B
build/block-library/blocks/query-title/editor-rtl.css 86 B
build/block-library/blocks/query-title/editor.css 86 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 169 B
build/block-library/blocks/quote/style.css 169 B
build/block-library/blocks/quote/theme-rtl.css 221 B
build/block-library/blocks/quote/theme.css 221 B
build/block-library/blocks/rss/editor-rtl.css 201 B
build/block-library/blocks/rss/editor.css 202 B
build/block-library/blocks/rss/style-rtl.css 290 B
build/block-library/blocks/rss/style.css 290 B
build/block-library/blocks/search/editor-rtl.css 211 B
build/block-library/blocks/search/editor.css 211 B
build/block-library/blocks/search/style-rtl.css 359 B
build/block-library/blocks/search/style.css 362 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 251 B
build/block-library/blocks/separator/style.css 251 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 476 B
build/block-library/blocks/shortcode/editor.css 476 B
build/block-library/blocks/site-logo/editor-rtl.css 465 B
build/block-library/blocks/site-logo/editor.css 465 B
build/block-library/blocks/site-logo/style-rtl.css 154 B
build/block-library/blocks/site-logo/style.css 154 B
build/block-library/blocks/site-tagline/editor-rtl.css 87 B
build/block-library/blocks/site-tagline/editor.css 87 B
build/block-library/blocks/site-title/editor-rtl.css 85 B
build/block-library/blocks/site-title/editor.css 85 B
build/block-library/blocks/social-link/editor-rtl.css 164 B
build/block-library/blocks/social-link/editor.css 165 B
build/block-library/blocks/social-links/editor-rtl.css 800 B
build/block-library/blocks/social-links/editor.css 799 B
build/block-library/blocks/social-links/style-rtl.css 1.34 kB
build/block-library/blocks/social-links/style.css 1.34 kB
build/block-library/blocks/spacer/editor-rtl.css 308 B
build/block-library/blocks/spacer/editor.css 308 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 478 B
build/block-library/blocks/table/editor.css 478 B
build/block-library/blocks/table/style-rtl.css 480 B
build/block-library/blocks/table/style.css 480 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/editor-rtl.css 551 B
build/block-library/blocks/template-part/editor.css 550 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/editor-rtl.css 90 B
build/block-library/blocks/term-description/editor.css 90 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 569 B
build/block-library/blocks/video/editor.css 570 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 1.29 kB
build/block-library/common.css 1.29 kB
build/block-library/reset-rtl.css 514 B
build/block-library/reset.css 515 B
build/block-library/theme-rtl.css 692 B
build/block-library/theme.css 693 B
build/block-serialization-default-parser/index.min.js 1.3 kB
build/block-serialization-spec-parser/index.min.js 3.06 kB
build/blocks/index.min.js 47.2 kB
build/components/style-rtl.css 15.9 kB
build/components/style.css 15.9 kB
build/customize-widgets/index.min.js 10.3 kB
build/customize-widgets/style-rtl.css 1.48 kB
build/customize-widgets/style.css 1.48 kB
build/data/index.min.js 7.22 kB
build/dom-ready/index.min.js 576 B
build/dom/index.min.js 4.78 kB
build/edit-navigation/style-rtl.css 3.12 kB
build/edit-navigation/style.css 3.12 kB
build/edit-post/classic-rtl.css 483 B
build/edit-post/classic.css 483 B
build/edit-post/style-rtl.css 7.25 kB
build/edit-post/style.css 7.24 kB
build/edit-site/style-rtl.css 5.04 kB
build/edit-site/style.css 5.03 kB
build/edit-widgets/style-rtl.css 3.88 kB
build/edit-widgets/style.css 3.89 kB
build/editor/style-rtl.css 3.88 kB
build/editor/style.css 3.88 kB
build/element/index.min.js 3.44 kB
build/escape-html/index.min.js 739 B
build/format-library/style-rtl.css 668 B
build/format-library/style.css 669 B
build/html-entities/index.min.js 628 B
build/is-shallow-equal/index.min.js 710 B
build/keyboard-shortcuts/index.min.js 1.74 kB
build/keycodes/index.min.js 1.43 kB
build/list-reusable-blocks/index.min.js 2.07 kB
build/list-reusable-blocks/style-rtl.css 842 B
build/list-reusable-blocks/style.css 842 B
build/notices/index.min.js 1.07 kB
build/nux/style-rtl.css 745 B
build/nux/style.css 742 B
build/plugins/index.min.js 1.99 kB
build/primitives/index.min.js 1.06 kB
build/react-i18n/index.min.js 924 B
build/redux-routine/index.min.js 2.82 kB
build/reusable-blocks/index.min.js 2.56 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/server-side-render/index.min.js 1.63 kB
build/token-list/index.min.js 847 B
build/url/index.min.js 1.95 kB
build/viewport/index.min.js 1.28 kB
build/widgets/style-rtl.css 1.04 kB
build/widgets/style.css 1.05 kB
build/wordcount/index.min.js 1.24 kB

compressed-size-action

@jasmussen
Copy link
Contributor

What an incredibly strong first offering. To me. this PR feels like it validates the idea of the object-fit size controls appearing after you've set both dimensions.

I'm seeing some weirdness with the sizing, though:

featured

Percent here doesn't seem to be working correctly, is it? Maybe it is. But

vw seems to be faring better:

take 2

For some reason the scale values don't appear to work at small dimensions:

contain

A few small things:

  • Default to PX unit — can we do that? If not, we might want to disable % by default.
  • There should be a default scale setting. fill is the default value for object-fit, so we could use that. But cover feels more useful — can we set that by default?
  • The new segmented control-style for this button group will need a little love. I'd love to help push some when you're ready for it.
  • Width and Height are both labels. Should Scale be a label for the entire segmented control?

Excellent work! Excited to see this land.

@jameskoster
Copy link
Contributor

The new segmented control-style for this button group will need a little love.

+1. Technical users will understand these terms, otherwise they have little meaning.

Sharing for potential inspiration there – YouTube playback quality options are listed as "1080p, 720p, 480p", etc on desktop. But I recently noticed that the mobile apps have a different take on that:

Maybe we can do something similar?

@jasmussen
Copy link
Contributor

To clarify I actually like the segmented control for this one. I was referring more to making it match the mockup.

That said, a dropdown would afford additional help text, that does make sense too.

But the thing I like the most about the segmented control is that its effect is so instant — you just click through the three options and the results are immediately visually evident, teaching you what each option does. Combined with the fact that there is a default, I think this would be a good place to start — that would also let us make headway on the control itself, which is needed elsewhere also.

One thing we could do is to just add some help text below, to clarify, and to change the "Fill" to "Stretch":

Featured Image i2

@jameskoster
Copy link
Contributor

the thing I like the most about the segmented control is that its effect is so instant — you just click through the three options and the results are immediately visually evident

Totally! I wasn't suggesting to change that. My point was mostly around the language. A label like "Contain" is going to be meaningless to the vast majority of people. You're correct that the canvas gives visual feedback – but only in the current context – it doesn't actually teach you what "Contain" means holistically. A few more words of description (or even just better labels, I like the "Stretch" example) might help make these more technical controls more digestible, and better assist visually impaired users?

Sorry for de-railing this PR, we can discuss this in a separate issue :D

@jasmussen
Copy link
Contributor

Not derailing at all, in fact very much on point. Stretch is one such step. But I didn't find a good single-word term to replace "contain". Something that encompasses "don't crop and don't stretch".

@jameskoster
Copy link
Contributor

Yes I don't think a single word will really cut it.

We have this area control in the template part creation flow:

Maybe we could use something like that, with similar descriptions to those found at https://www.w3schools.com/css/css3_object-fit.asp ?

Or, could we display a thumbnail preview, kind of like the style picker?

Screenshot 2021-05-10 at 10 27 15

That would totally eliminate the mystery and the need to click through each option to visualise its effects. A tooltip could reveal the detailed description 🤔

@jasmussen
Copy link
Contributor

The thumbnail preview might work. But we'd need a great image where the differential between the three styles is clear.

@ntsekouras
Copy link
Contributor Author

ntsekouras commented May 10, 2021

I addressed some of the feedback:

  1. px as starting unit
  2. default to cover
  3. change wording to stretch

Width and Height are both labels. Should Scale be a label for the entire segmented control?

I tried finding a nice way to do this but found some problems with the label behavior.

When a is clicked or tapped and it is associated with a form control, the resulting click event is also raised for the associated control.

For some reason the scale values don't appear to work at small dimensions:

I think this is resolved now. I added width:100% to the image as our width control is affecting the parent figure element.

for this button group will need a little love

Feel free to push any enhancements you like 😄

@jasmussen
Copy link
Contributor

I'm tinkering with some things and encountered this situation:

featured

Observe how if you add only a height, the image immediately gets super stretched.

If, however, you only add a width, the image looks fine and non-stretched.

This is because we have the following 100% width rule:

Screenshot 2021-05-10 at 15 31 40

In other words, if you add only a height but no width, you actually do have a width — 100%. Which would also benefit from the "cover" scaling property.

Can we try a change so that the cover/contain/stretch control also becomes available if you add just a height? I.e. show the control if there's a height, or a height and a width.

@jasmussen
Copy link
Contributor

Another question, I'm looking at the segmented control:

Screenshot 2021-05-10 at 15 39 40

It looks like a one-off for the featured control here for now, and that might be a fine way to dip our toes in? Alternately, should we already now start to extract this one as its own control that can be used in other places? We'll need it for the nav block also #30370

Otherwise let me know and I'll just style according to the block-library-post-featured-image-scale-controls class.

@ntsekouras
Copy link
Contributor Author

ntsekouras commented May 10, 2021

It looks like a one-off for the featured control here for now, and that might be a fine way to dip our toes in? Alternately, should we already now start to extract this one as its own control that can be used in other places?

That I believe is more of a design folks decision. IMO this functionality will be much needed and 5.8 is really close 😄 Either way I'm happy to help creating the new control if needed now.

--edit:

Otherwise let me know and I'll just style according to the block-library-post-featured-image-scale-controls class.

If we are okay to style this one, your help would be great for sure 💯

@ntsekouras ntsekouras force-pushed the try/featured-image-dimensions branch from 4abc6d1 to 2c4edcc Compare May 10, 2021 14:16
@mtias
Copy link
Member

mtias commented May 11, 2021

Let's try to get the version that is already implemented for the g2-repo here if possible.

@miminari
Copy link
Member

This is nice!
I was just searching for a way to add object-fit to core Image Block styles in my own plugins and found this PR.
I would like to also add the object-fit control to Image Block. Have you considered that yet?

@ntsekouras ntsekouras force-pushed the try/featured-image-dimensions branch from 702f2d3 to c40bd8f Compare July 19, 2021 15:33
@kjellr
Copy link
Contributor

kjellr commented Jul 20, 2021

This is really helpful! It's working well in my testing:

featured-image

The only thing I'm missing is some sort of reset option: there's no button, and deleting entered values doesn't seem to work either.

@ntsekouras
Copy link
Contributor Author

The only thing I'm missing is some sort of reset option: there's no button, and deleting entered values doesn't seem to work either.

Good catch! Thanks! Fixed..

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the reset. This works well in my testing, and seems like a good v1 in case we want to iterate further later on. 👍

@ntsekouras ntsekouras merged commit c96feeb into trunk Jul 30, 2021
@ntsekouras ntsekouras deleted the try/featured-image-dimensions branch July 30, 2021 20:03
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Jul 30, 2021
@antonyjsmith
Copy link

This is great, I love it, but this now differs when compared to images blocks yet they are in most respects doing the same thing (full disclosure I think the image block is poor) back to my main point though, this lack of consistency confuses users.

@paaljoachim
Copy link
Contributor

I am wondering where we can extend these new controls to other blocks where it is natural to add them?
As @antonyjsmith says having consistency is important.
Perhaps something to look into for the Image block? @Mamaduka

@antonyjsmith
Copy link

antonyjsmith commented Jul 30, 2021

Consistency is absolutely critical. Decisions needs to be considered prior to implementation and to meet a predefined specification otherwise you end up with what Gutenberg currently is. An inconsistent perpetual beta.

@ntsekouras
Copy link
Contributor Author

Consistency is absolutely critical

I agree 100% here and improvements are always being implemented. This is a big and difficult task and we have to tackle this with discussion, new issues and iterations. While some blocks have similarities, the consolidation of them is not so simple.

There are already some issues about consistency for UX and API like this one and we will get there step by step 😄 .

@NicoHood
Copy link

NicoHood commented Oct 1, 2021

Can anybody tell me in which version of Gutenberg this feature has landed? It is not available in wordpress 5.8, even though it was mentioned in the PR description, is that correct?

@ntsekouras
Copy link
Contributor Author

👋 @NicoHood !

You can see in every merged PR the Gutenberg version in the Milestone section, which in this case is 11.3. This PR landed after WP 5.8 and will be in the upcoming 5.9 version.

FYI: you can see here the GB versions in each WP version 😄

@NicoHood
Copy link

NicoHood commented Oct 1, 2021

Nice, thanks!

Is there also an option to select a WordPress predefined image format (like Middle, Large, Thumbnail etc.)? If not, is this issue being tracked somewhere?

Sorry for being a bit lost here.

@ntsekouras
Copy link
Contributor Author

It's tracked here: #33789

@NicoHood
Copy link

NicoHood commented Oct 1, 2021

Is there a way to get this feature with the current WordPress 5.8 and maybe a hidden hook? I would like to set all feature images of the query loop to a specific size. I am not sure if using the additional gutenberg plugin is a good idea for a stable running site.

@ntsekouras
Copy link
Contributor Author

Is there a way to get this feature with the current WordPress 5.8 and maybe a hidden hook?

I don't think so. It's in the plugin

@markhowellsmead
Copy link

There's no way to select which registered image size is to be used for the base of this block; e.g. in the post query loop, we need to be able to choose that e.g. thumbnail should be used (so that no massive images are loaded). See also #33789 (comment)

@ntsekouras
Copy link
Contributor Author

See also #33789 (comment)

That's the existing issue for your request. Thanks for commenting there.

@markhowellsmead
Copy link

Have already done so: #33789 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured Image block: Allow free-form resizing