Code Quality: Rename construct_wp_query_args to build_query_vars_from_query_block
#32041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom_query_block`
gziolo
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
gziolo
changed the title
construct_wp_query_args to `build_query_vars_from_query_blockconstruct_wp_query_args to build_query_vars_from_query_block
gziolo
commented
May 20, 2021
| @@ -19,7 +19,7 @@ | |||
| * | |||
| * @return array Returns the constructed WP_Query arguments. | |||
| */ | |||
| function construct_wp_query_args( $block, $page ) { | |||
| function build_query_vars_from_query_block( $block, $page ) { | |||
There was a problem hiding this comment.
@ntsekouras, should we update the second param to accept an array of settings or $page is all that is necessary here?
There was a problem hiding this comment.
$page is enough and I can't think of any other settings for now.
28 tasks
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A simple rename refactoring to give a function a less generic name. It still needs to be backported to WordPress core.
How has this been tested?
Ensure all tests pass and Query blocks work as before.