[Block Library - Query Loop]: Set default block variations not to inherit from global query #33163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erit from global query
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
mcsf,
youknowriad,
aristath,
kjellr,
jasmussen and
carolinan
|
Size Change: +32 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
Thanks Nik! That will be very helpful! |
|
The query block is an interesting one, I've always thought of it as a block you should not manually insert and configure that often, if ever, and that the primary point of interaction with it is through (future) higher level blocks that wrap around it. Correct me if I'm wrong: this PR is mostly about ensuring what you see when you insert the block in a post is more predictably what you get/expect? I.e. since in the editor we can't know what query is inherited, it'll rarely be accurate. In that vein, the change seems fine to me: if you do insert this block manually, it's probably because you want to make your own custom little loop. The downside is if you're actually a theme developer building a template, you should probably be inheriting the query on this block. Right? Happy to give a green check, but just wanted to understand the motivation. Thanks as always for your work. |
It has this effect for now in 5.8 that we don't have the
Exactly, but I believe we'll solve this for 5.9. So this PR better suits the current usage of |
|
I thought it was to make sure that all default variations match? |
It is! I'm just explaining why the block patterns were changed to this default as well here: #31856 |
youknowriad
removed
the
Backport to WP Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
…erit from global query (#33163)
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
…erit from global query (#33163)
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
…erit from global query (#33163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just adds as a default argument of
inherittofalsefor the defaultQuery Loopvariations. Since we have this default value in current available patterns and the block will be exposed in post/page editors for 5.8, this setting makes more sense for now. An issue for dynamic calculating and setting this value is here:#30369Testing instructions
Query Loopblock in a pageQuery Loopblock and clickStart blankinheritvalue tofalseand allow you to customize the query properties, and of course that they work properly as before.Before
Screen.Recording.2021-07-02.at.12.34.58.PM.mov
After
Screen.Recording.2021-07-02.at.12.34.08.PM.mov