Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Interface: Make permalinks documentation URL translatable #34282

Merged
merged 2 commits into from Aug 25, 2021

Conversation

nukaga
Copy link
Contributor

@nukaga nukaga commented Aug 25, 2021

Description

The "Read about permalinks" links are not properly i18n enabled, so they all jump to the English documentation.
All "Read about permalinks" in the inspector of the editor are linked to https://wordpress.org/support/article/writing-posts/#post-field-descriptions in English. I would like to be able to jump to the documentation for each language.

https://core.trac.wordpress.org/ticket/54001

There is a document that has been translated into Japanese, so the link should be to the document in the same language, not English.

Example:

English
https://wordpress.org/support/article/writing-posts/#post-field-descriptions

Japanese
https://ja.wordpress.org/support/article/writing-posts/#%e3%83%91%e3%83%bc%e3%83%9e%e3%83%aa%e3%83%b3%e3%82%af

How has this been tested?

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka added General Interface Parts of the UI which don't fall neatly under other labels. Internationalization (i18n) Issues or PRs related to internationalization efforts labels Aug 25, 2021
Co-authored-by: Hiroshi Urabe <mail@torounit.com>
Copy link
Member

@torounit torounit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mamaduka Mamaduka changed the title Make the URL translatable. General Interface: Make permalinks documentation URL translatable Aug 25, 2021
@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label Aug 25, 2021
@Mamaduka
Copy link
Member

Thanks for your contribution, @nukaga.

I've updated the PR title for the auto-generated changelog.

@Mamaduka Mamaduka merged commit b838d55 into WordPress:trunk Aug 25, 2021
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants