Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
This PR is referencing this issue #3430
Added Escape key to keyboard shortcuts so multi-block unselect works via keyboard as well.
How Has This Been Tested?
This is probably for separate issue but since it's related I put the info here.
This is the problem:
Changing 'pageLoadTimeout' does not make any difference.
I have not included 003-multi-block-selection.js so original tests pass.
@vladanost I'd love if you can include the test you wrote, so I can try it locally and see why it fails.
By the way there's a built-in environment and cypress setup you can use to avoid having to setup it yourself https://github.com/WordPress/gutenberg/blob/master/CONTRIBUTING.md#local-environment and https://github.com/WordPress/gutenberg/blob/master/CONTRIBUTING.md#end-to-end-testing-integration-tests
@@ Coverage Diff @@ ## master #3436 +/- ## ========================================== + Coverage 33.8% 34.01% +0.21% ========================================== Files 249 252 +3 Lines 6713 6703 -10 Branches 1207 1217 +10 ========================================== + Hits 2269 2280 +11 + Misses 3754 3730 -24 - Partials 690 693 +3