New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adding an audio block doesn't update the toolbar #3443

Merged
merged 3 commits into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@PareshRadadiya
Contributor

PareshRadadiya commented Nov 12, 2017

Description

This PR is referencing this issue #3385

Added controls to update the toolbar while adding an audio.

How Has This Been Tested?

Passed all test in npm test run

Screenshots (jpeg or gifs if applicable):

selection_001

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Nov 13, 2017

Contributor

I guess we can now group the controls and inspectorControls variables together since they are used at the exact same places. (Same is done for the video block)

Contributor

youknowriad commented Nov 13, 2017

I guess we can now group the controls and inspectorControls variables together since they are used at the exact same places. (Same is done for the video block)

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 14, 2017

Codecov Report

Merging #3443 into master will increase coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
+ Coverage    33.8%   34.17%   +0.37%     
==========================================
  Files         249      258       +9     
  Lines        6713     6754      +41     
  Branches     1207     1223      +16     
==========================================
+ Hits         2269     2308      +39     
  Misses       3754     3754              
- Partials      690      692       +2
Impacted Files Coverage Δ
blocks/library/audio/index.js 12.5% <0%> (+0.37%) ⬆️
blocks/library/button/index.js 11.11% <0%> (-8.89%) ⬇️
blocks/library/gallery/index.js 25.92% <0%> (-5.9%) ⬇️
editor/effects.js 45.88% <0%> (-5.44%) ⬇️
components/autocomplete/index.js 73.26% <0%> (-4.21%) ⬇️
editor/actions.js 43.39% <0%> (-0.84%) ⬇️
editor/components/provider/index.js 12.5% <0%> (-0.84%) ⬇️
blocks/api/factory.js 87.17% <0%> (-0.63%) ⬇️
editor/reducer.js 90.27% <0%> (-0.5%) ⬇️
blocks/library/freeform/old-editor.js 1.36% <0%> (-0.15%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ef252...3115678. Read the comment docs.

codecov bot commented Nov 14, 2017

Codecov Report

Merging #3443 into master will increase coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
+ Coverage    33.8%   34.17%   +0.37%     
==========================================
  Files         249      258       +9     
  Lines        6713     6754      +41     
  Branches     1207     1223      +16     
==========================================
+ Hits         2269     2308      +39     
  Misses       3754     3754              
- Partials      690      692       +2
Impacted Files Coverage Δ
blocks/library/audio/index.js 12.5% <0%> (+0.37%) ⬆️
blocks/library/button/index.js 11.11% <0%> (-8.89%) ⬇️
blocks/library/gallery/index.js 25.92% <0%> (-5.9%) ⬇️
editor/effects.js 45.88% <0%> (-5.44%) ⬇️
components/autocomplete/index.js 73.26% <0%> (-4.21%) ⬇️
editor/actions.js 43.39% <0%> (-0.84%) ⬇️
editor/components/provider/index.js 12.5% <0%> (-0.84%) ⬇️
blocks/api/factory.js 87.17% <0%> (-0.63%) ⬇️
editor/reducer.js 90.27% <0%> (-0.5%) ⬇️
blocks/library/freeform/old-editor.js 1.36% <0%> (-0.15%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ef252...3115678. Read the comment docs.

@aduth

aduth approved these changes Nov 14, 2017

@youknowriad youknowriad merged commit 025f964 into WordPress:master Nov 20, 2017

2 checks passed

codecov/project 34.17% (+0.37%) compared to 04ef252
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad
Contributor

youknowriad commented Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment