New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change z-index to fix block mover over link input #3471

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
2 participants
@Rahmon
Contributor

Rahmon commented Nov 14, 2017

Description

Block mover handles showing over link input #3464

How Has This Been Tested?

This has been tested with "npm test", "npm run test-e2e" and manually on Chrome and Firefox.

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Nov 15, 2017

Member

Should the mover be lowered? Not sure why it would need to be so high in the first place.

Member

aduth commented Nov 15, 2017

Should the mover be lowered? Not sure why it would need to be so high in the first place.

@Rahmon

This comment has been minimized.

Show comment
Hide comment
@Rahmon

Rahmon Nov 16, 2017

Contributor

I set the z-index of mover to be lower and it's worked.

Contributor

Rahmon commented Nov 16, 2017

I set the z-index of mover to be lower and it's worked.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 16, 2017

Codecov Report

Merging #3471 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
+ Coverage   34.16%   34.54%   +0.38%     
==========================================
  Files         257      261       +4     
  Lines        6735     6710      -25     
  Branches     1220     1225       +5     
==========================================
+ Hits         2301     2318      +17     
+ Misses       3742     3704      -38     
+ Partials      692      688       -4
Impacted Files Coverage Δ
blocks/library/shortcode/index.js 40% <0%> (-10%) ⬇️
blocks/library/verse/index.js 28.57% <0%> (-8.93%) ⬇️
blocks/library/code/index.js 50% <0%> (-7.15%) ⬇️
blocks/library/html/index.js 16.66% <0%> (-6.42%) ⬇️
blocks/library/preformatted/index.js 44.44% <0%> (-5.56%) ⬇️
blocks/library/table/index.js 36.36% <0%> (-5.31%) ⬇️
blocks/library/text-columns/index.js 28.57% <0%> (-4.77%) ⬇️
blocks/library/video/index.js 16.66% <0%> (-4.39%) ⬇️
blocks/library/heading/index.js 25% <0%> (-3.58%) ⬇️
blocks/library/cover-image/index.js 30.43% <0%> (-2.9%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd8cd0...348ea58. Read the comment docs.

codecov bot commented Nov 16, 2017

Codecov Report

Merging #3471 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
+ Coverage   34.16%   34.54%   +0.38%     
==========================================
  Files         257      261       +4     
  Lines        6735     6710      -25     
  Branches     1220     1225       +5     
==========================================
+ Hits         2301     2318      +17     
+ Misses       3742     3704      -38     
+ Partials      692      688       -4
Impacted Files Coverage Δ
blocks/library/shortcode/index.js 40% <0%> (-10%) ⬇️
blocks/library/verse/index.js 28.57% <0%> (-8.93%) ⬇️
blocks/library/code/index.js 50% <0%> (-7.15%) ⬇️
blocks/library/html/index.js 16.66% <0%> (-6.42%) ⬇️
blocks/library/preformatted/index.js 44.44% <0%> (-5.56%) ⬇️
blocks/library/table/index.js 36.36% <0%> (-5.31%) ⬇️
blocks/library/text-columns/index.js 28.57% <0%> (-4.77%) ⬇️
blocks/library/video/index.js 16.66% <0%> (-4.39%) ⬇️
blocks/library/heading/index.js 25% <0%> (-3.58%) ⬇️
blocks/library/cover-image/index.js 30.43% <0%> (-2.9%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd8cd0...348ea58. Read the comment docs.

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Nov 16, 2017

Member

Was already lowered once in dbb9742 so I think it should be fine to do so here.

Member

aduth commented Nov 16, 2017

Was already lowered once in dbb9742 so I think it should be fine to do so here.

@aduth

aduth approved these changes Nov 16, 2017

👍

@aduth aduth merged commit e7aaa99 into WordPress:master Nov 16, 2017

2 checks passed

codecov/project 34.54% (+0.38%) compared to cbd8cd0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rahmon Rahmon deleted the Rahmon:fix/3464 branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment