New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post date color and added breakpoint to grid in latest posts block. #3477

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@samikeijonen
Contributor

samikeijonen commented Nov 14, 2017

Description

Update post date color to $dark-gray-300 which meats accessibility guidelines on white background. Other backgrounds can be a problem.

Also added breakpoint on grid.

How Has This Been Tested?

  • Run npm test without errors.
  • Testes front-end with default themes and random .org themes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@samikeijonen samikeijonen changed the title from Update post date color and grid in latest posts block. to Update post date color and added breakpoint to grid in latest posts block. Nov 14, 2017

@afercia afercia requested a review from aduth Dec 12, 2017

@aduth

aduth approved these changes Dec 13, 2017

}
}
&.columns-1 li {

This comment has been minimized.

@aduth

aduth Dec 13, 2017

Member

Was it intentional to drop the columns-1 styles? I guess it would make sense, since we wouldn't want the single column width to be constrained.

@aduth

aduth Dec 13, 2017

Member

Was it intentional to drop the columns-1 styles? I guess it would make sense, since we wouldn't want the single column width to be constrained.

This comment has been minimized.

@samikeijonen

samikeijonen Dec 13, 2017

Contributor

Yes, it was intentional. One column layout would be default width: auto. We'll come back to columns grid later on. But I think it doesn't hurt to start basics like this.

@samikeijonen

samikeijonen Dec 13, 2017

Contributor

Yes, it was intentional. One column layout would be default width: auto. We'll come back to columns grid later on. But I think it doesn't hurt to start basics like this.

This comment has been minimized.

@aduth

aduth Dec 13, 2017

Member

The slider control doesn't allow the value of columns to be set to 6. Should we also limit the loop to stop at 5?

@aduth

aduth Dec 13, 2017

Member

The slider control doesn't allow the value of columns to be set to 6. Should we also limit the loop to stop at 5?

This comment has been minimized.

@samikeijonen

samikeijonen Dec 13, 2017

Contributor

Yeah, I was about to ask about slider setting. If it's not filterable it makes sense to stop loop at 5.

@samikeijonen

samikeijonen Dec 13, 2017

Contributor

Yeah, I was about to ask about slider setting. If it's not filterable it makes sense to stop loop at 5.

This comment has been minimized.

@samikeijonen

samikeijonen Dec 31, 2017

Contributor

Hmm I can still see that you can set columns to be set to 6. I'm leaving CSS as it is for now.

All the blocks that have grid view should have same or similar grid CSS (grid gap, margins) though. We can discuss it later on, do we use CSS Grid etc.

@samikeijonen

samikeijonen Dec 31, 2017

Contributor

Hmm I can still see that you can set columns to be set to 6. I'm leaving CSS as it is for now.

All the blocks that have grid view should have same or similar grid CSS (grid gap, margins) though. We can discuss it later on, do we use CSS Grid etc.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 31, 2017

Codecov Report

Merging #3477 into master will decrease coverage by 4.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3477      +/-   ##
==========================================
- Coverage   39.17%   34.22%   -4.95%     
==========================================
  Files         299      257      -42     
  Lines        7025     6740     -285     
  Branches     1292     1223      -69     
==========================================
- Hits         2752     2307     -445     
- Misses       3588     3741     +153     
- Partials      685      692       +7
Impacted Files Coverage Δ
components/panel/row.js 0% <0%> (-100%) ⬇️
blocks/block-controls/index.js 0% <0%> (-100%) ⬇️
blocks/url-input/button.js 0% <0%> (-100%) ⬇️
components/notice/index.js 0% <0%> (-100%) ⬇️
blocks/color-palette/index.js 0% <0%> (-90.91%) ⬇️
blocks/alignment-toolbar/index.js 16.66% <0%> (-83.34%) ⬇️
editor/components/post-last-revision/check.js 0% <0%> (-75%) ⬇️
editor/components/post-taxonomies/index.js 28.57% <0%> (-57.15%) ⬇️
editor/components/document-outline/index.js 17.85% <0%> (-57.15%) ⬇️
blocks/block-alignment-toolbar/index.js 33.33% <0%> (-55.56%) ⬇️
... and 270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976f8c6...d76f0e5. Read the comment docs.

codecov bot commented Dec 31, 2017

Codecov Report

Merging #3477 into master will decrease coverage by 4.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3477      +/-   ##
==========================================
- Coverage   39.17%   34.22%   -4.95%     
==========================================
  Files         299      257      -42     
  Lines        7025     6740     -285     
  Branches     1292     1223      -69     
==========================================
- Hits         2752     2307     -445     
- Misses       3588     3741     +153     
- Partials      685      692       +7
Impacted Files Coverage Δ
components/panel/row.js 0% <0%> (-100%) ⬇️
blocks/block-controls/index.js 0% <0%> (-100%) ⬇️
blocks/url-input/button.js 0% <0%> (-100%) ⬇️
components/notice/index.js 0% <0%> (-100%) ⬇️
blocks/color-palette/index.js 0% <0%> (-90.91%) ⬇️
blocks/alignment-toolbar/index.js 16.66% <0%> (-83.34%) ⬇️
editor/components/post-last-revision/check.js 0% <0%> (-75%) ⬇️
editor/components/post-taxonomies/index.js 28.57% <0%> (-57.15%) ⬇️
editor/components/document-outline/index.js 17.85% <0%> (-57.15%) ⬇️
blocks/block-alignment-toolbar/index.js 33.33% <0%> (-55.56%) ⬇️
... and 270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976f8c6...d76f0e5. Read the comment docs.

@aduth aduth merged commit f15a54f into WordPress:master Jan 3, 2018

2 checks passed

codecov/project 39.17% remains the same compared to 976f8c6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@samikeijonen samikeijonen deleted the samikeijonen:update/latest-posts branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment