New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract BlockToolbar as a reusable component #3491

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
1 participant
@youknowriad
Contributor

youknowriad commented Nov 15, 2017

Related to #2761 (comment)

This PR extracts BlockToolbar component to the reusable components folder by removing all layout styles from the reusable components.

Notes

  • This also extracts BlockMover, BlockSettingsMenu and BlockSwitcher. These are components used by the BlockToolbar and also by another reusable component (BlockList not yet made reusable), so I decided to move them to the reusable components folder but without exposing them in wp.editor because reusing those explicitely to build alternative editor layouts makes no sense, we reuse BlockToolbar or BlockList instead of including those directly.

Testing instructions

  • Test that the Block Inspector works and looks like master.

@youknowriad youknowriad self-assigned this Nov 15, 2017

@youknowriad youknowriad requested a review from gziolo Nov 15, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 15, 2017

Codecov Report

Merging #3491 into master will increase coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3491      +/-   ##
==========================================
+ Coverage   34.64%   34.82%   +0.18%     
==========================================
  Files         260      260              
  Lines        6737     6704      -33     
  Branches     1219     1215       -4     
==========================================
+ Hits         2334     2335       +1     
+ Misses       3717     3687      -30     
+ Partials      686      682       -4
Impacted Files Coverage Δ
...ponents/block-settings-menu/block-delete-button.js 0% <ø> (ø)
...omponents/block-settings-menu/block-mode-toggle.js 44.44% <ø> (ø)
...omponents/block-settings-menu/unknown-converter.js 0% <ø> (ø)
editor/components/block-mover/index.js 10% <ø> (ø)
editor/components/block-toolbar/index.js 0% <ø> (ø)
...ents/block-settings-menu/block-inspector-button.js 0% <ø> (ø)
editor/components/block-mover/mover-label.js 100% <ø> (ø)
editor/components/block-switcher/index.js 2.85% <ø> (ø)
editor/components/block-settings-menu/index.js 0% <0%> (ø)
...or/modes/visual-editor/block-contextual-toolbar.js 0% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc86a9...9739bb6. Read the comment docs.

codecov bot commented Nov 15, 2017

Codecov Report

Merging #3491 into master will increase coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3491      +/-   ##
==========================================
+ Coverage   34.64%   34.82%   +0.18%     
==========================================
  Files         260      260              
  Lines        6737     6704      -33     
  Branches     1219     1215       -4     
==========================================
+ Hits         2334     2335       +1     
+ Misses       3717     3687      -30     
+ Partials      686      682       -4
Impacted Files Coverage Δ
...ponents/block-settings-menu/block-delete-button.js 0% <ø> (ø)
...omponents/block-settings-menu/block-mode-toggle.js 44.44% <ø> (ø)
...omponents/block-settings-menu/unknown-converter.js 0% <ø> (ø)
editor/components/block-mover/index.js 10% <ø> (ø)
editor/components/block-toolbar/index.js 0% <ø> (ø)
...ents/block-settings-menu/block-inspector-button.js 0% <ø> (ø)
editor/components/block-mover/mover-label.js 100% <ø> (ø)
editor/components/block-switcher/index.js 2.85% <ø> (ø)
editor/components/block-settings-menu/index.js 0% <0%> (ø)
...or/modes/visual-editor/block-contextual-toolbar.js 0% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc86a9...9739bb6. Read the comment docs.

@youknowriad youknowriad merged commit 5b3bce0 into master Nov 16, 2017

3 checks passed

codecov/project 34.82% (+0.18%) compared to dbc86a9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/extract-block-toolbar branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment