Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix button link modal not closing #3508
Button link suggestion modal could only be closed buy first using arrow keys and pressing ENTER afterwards. When clicked, the link changed but the modal was stuck.
How Has This Been Tested?
JS unit test passing
Types of changes
I added a new method to handle this.
@@ Coverage Diff @@ ## master #3508 +/- ## ========================================== + Coverage 34.61% 35.28% +0.67% ========================================== Files 261 267 +6 Lines 6769 6745 -24 Branches 1231 1221 -10 ========================================== + Hits 2343 2380 +37 + Misses 3733 3688 -45 + Partials 693 677 -16
This looks to be a good intermediary fix, but I'm generally concerned about the behavior of the visible suggestions list being tied to a selection more than it is to input focus. There's also several places within
URLInput we manage this: in input handlers, change handlers, selection handlers. Could do for some more refactoring I think, but fine for subsequent pull requests.