New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract a reusable post title component #3517

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Nov 16, 2017

Related to #2761 (comment)

This PR extracts PostTitle component to the reusable components folder by removing all layout styles from the reusable components.

Notes

  • This also extracts PostPermalnk, BlockSettingsMenu and BlockSwitcher but it's not exposed because it shouldn't be used directly (yet).

  • This also includes a small redesign to the post permalink modal to match the latest block toolbar design

Testing instructions

  • Test that the Post Title works and looks like master.

@youknowriad youknowriad self-assigned this Nov 16, 2017

@youknowriad youknowriad requested a review from jasmussen Nov 16, 2017

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Nov 20, 2017

Contributor

Nice, just testing the title component, everything seems to work as it used to, so in that vein, 👍 👍

I did notice some arrow key weirdness, but there's every chance this is unrelated to this PR, but is indeed present in master. After using arrow keys between title and paragraph at some point the caret starts ending up in the middle of the paragraph block:

arrows

Contributor

jasmussen commented Nov 20, 2017

Nice, just testing the title component, everything seems to work as it used to, so in that vein, 👍 👍

I did notice some arrow key weirdness, but there's every chance this is unrelated to this PR, but is indeed present in master. After using arrow keys between title and paragraph at some point the caret starts ending up in the middle of the paragraph block:

arrows

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Nov 20, 2017

Contributor

Just cc @mcsf @iseulde about the arrow navigation error above which is not related to this PR

Contributor

youknowriad commented Nov 20, 2017

Just cc @mcsf @iseulde about the arrow navigation error above which is not related to this PR

@youknowriad youknowriad merged commit d6af47f into master Nov 20, 2017

2 of 3 checks passed

codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/extract-post-title branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment