New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/3428: Update convertToBlocks rawHandler call to specify mode #3526

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
3 participants
@EphoxJames
Contributor

EphoxJames commented Nov 17, 2017

Description

Fixes #3428
It looks like the rawHandler was changed to use the string-enum parameter mode instead of the boolean parameter inline at some point and this broke convertToBlocks for inline input like empty string.

How Has This Been Tested?

Manual check in Firefox and Chrome.

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
fix/3428: Update convertToBlocks rawHandler call to specify mode
It looks like the rawHandler was changed to use mode instead of inline
at some point and this broke convertToBlocks for inline input.

@EphoxJames EphoxJames self-assigned this Nov 17, 2017

@EphoxJames EphoxJames requested review from gziolo and iseulde Nov 17, 2017

@EphoxJames EphoxJames added this to In Progress in Ephox Team Nov 17, 2017

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Nov 17, 2017

Member

It looks like a fixed regression. It doesn't create any block if Classic Text block is empty, which is a very expected behavior.

Member

gziolo commented Nov 17, 2017

It looks like a fixed regression. It doesn't create any block if Classic Text block is empty, which is a very expected behavior.

@gziolo gziolo merged commit 0065d21 into master Nov 17, 2017

3 checks passed

codecov/project 34.54% remains the same compared to 38d0c74
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gziolo gziolo deleted the fix/3428-set-rawhandler-mode branch Nov 17, 2017

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Nov 17, 2017

Member

Thanks for fixing 💯

Member

gziolo commented Nov 17, 2017

Thanks for fixing 💯

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde

iseulde Nov 17, 2017

Member

Thanks!

Member

iseulde commented Nov 17, 2017

Thanks!

@EphoxJames EphoxJames moved this from In Progress to Done in Ephox Team Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment