Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop currentColor from button background #3556
This fixes #3460
Alas, if the theme uses a dark background, then the text will likely be light. That means a light button with white text.
I tried using CSS color inversion. This worked for making the text color be the inverse of the button color:
Clever right? It not only inverses the text color, but it also increases the contrast with the blend mode.
Alas, the blend mode isn't very widely supported. So I just changed to a dark gray background:
@@ Coverage Diff @@ ## master #3556 +/- ## ========================================== - Coverage 35.05% 34.93% -0.12% ========================================== Files 263 268 +5 Lines 6703 6849 +146 Branches 1220 1240 +20 ========================================== + Hits 2350 2393 +43 - Misses 3675 3764 +89 - Partials 678 692 +14