New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Increase the minimum width/height of a resized image #3574

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Nov 20, 2017

closes #3361

Once the image is too small, it's hard to reselect the image agains. This increases the min size a little bit to make it easier.

Testing instructions

  • Add an image block (with an image)
  • Resize the image to it's smallest possible size
  • Click outside the block to deselect
  • Click the image to select it

@youknowriad youknowriad added the Blocks label Nov 20, 2017

@youknowriad youknowriad self-assigned this Nov 20, 2017

@youknowriad youknowriad requested review from mtias, gziolo and jasmussen Nov 20, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 20, 2017

Codecov Report

Merging #3574 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3574      +/-   ##
==========================================
+ Coverage   35.15%   35.16%   +<.01%     
==========================================
  Files         265      265              
  Lines        6721     6722       +1     
  Branches     1216     1216              
==========================================
+ Hits         2363     2364       +1     
  Misses       3683     3683              
  Partials      675      675
Impacted Files Coverage Δ
blocks/library/image/block.js 1.85% <33.33%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb3729...a124f64. Read the comment docs.

codecov bot commented Nov 20, 2017

Codecov Report

Merging #3574 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3574      +/-   ##
==========================================
+ Coverage   35.15%   35.16%   +<.01%     
==========================================
  Files         265      265              
  Lines        6721     6722       +1     
  Branches     1216     1216              
==========================================
+ Hits         2363     2364       +1     
  Misses       3683     3683              
  Partials      675      675
Impacted Files Coverage Δ
blocks/library/image/block.js 1.85% <33.33%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb3729...a124f64. Read the comment docs.

@mtias

mtias approved these changes Nov 20, 2017

@youknowriad youknowriad merged commit 6dded29 into master Nov 20, 2017

3 checks passed

codecov/project 35.16% (+<.01%) compared to 7bb3729
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/increase-image-min-size branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment