New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: Target end-of-content styles to specific inserter #3597

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Nov 21, 2017

Regression introduced in #3546

This pull request seeks to resolve a styling issue with the between-inserter where it appears positioned lower than it should be. This was an unanticipated side effect of moving styles in #3546 where two styles of equal specificity were reordered. The proposed changes here eliminate one of these two styles, moving instead the intended styling to target the end-of-content inserter more specifically, instead of applying styles to all inserters within the visual editor.

Before After
Before After

Testing instructions:

Verify that the between-inserter is positioned vertically as expected (at the mid point on the top and bottom lines of a selected block).

Verify that the end-of-content inserter is positioned as expected (aligned horizontally to left of block content), in small and large viewports.

@aduth aduth merged commit 0917597 into master Nov 21, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@aduth aduth deleted the fix/between-inserter-styling branch Nov 21, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 21, 2017

Codecov Report

Merging #3597 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3597      +/-   ##
==========================================
- Coverage   36.56%   36.41%   -0.16%     
==========================================
  Files         267      267              
  Lines        6632     6660      +28     
  Branches     1203     1210       +7     
==========================================
  Hits         2425     2425              
- Misses       3554     3575      +21     
- Partials      653      660       +7
Impacted Files Coverage Δ
editor/components/block-list/sibling-inserter.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8aadb...7f925b7. Read the comment docs.

codecov bot commented Nov 21, 2017

Codecov Report

Merging #3597 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3597      +/-   ##
==========================================
- Coverage   36.56%   36.41%   -0.16%     
==========================================
  Files         267      267              
  Lines        6632     6660      +28     
  Branches     1203     1210       +7     
==========================================
  Hits         2425     2425              
- Misses       3554     3575      +21     
- Partials      653      660       +7
Impacted Files Coverage Δ
editor/components/block-list/sibling-inserter.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8aadb...7f925b7. Read the comment docs.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Nov 21, 2017

Contributor

Sorry I missed the review ping. But nice work.

Contributor

jasmussen commented Nov 21, 2017

Sorry I missed the review ping. But nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment