Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Inserter: Target end-of-content styles to specific inserter #3597
Regression introduced in #3546
This pull request seeks to resolve a styling issue with the between-inserter where it appears positioned lower than it should be. This was an unanticipated side effect of moving styles in #3546 where two styles of equal specificity were reordered. The proposed changes here eliminate one of these two styles, moving instead the intended styling to target the end-of-content inserter more specifically, instead of applying styles to all inserters within the visual editor.
Verify that the between-inserter is positioned vertically as expected (at the mid point on the top and bottom lines of a selected block).
Verify that the end-of-content inserter is positioned as expected (aligned horizontally to left of block content), in small and large viewports.
referenced this pull request
Nov 21, 2017
Nov 21, 2017
@@ Coverage Diff @@ ## master #3597 +/- ## ========================================== - Coverage 36.56% 36.41% -0.16% ========================================== Files 267 267 Lines 6632 6660 +28 Branches 1203 1210 +7 ========================================== Hits 2425 2425 - Misses 3554 3575 +21 - Partials 653 660 +7