New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockList: Extract the fixedToolbar flag as a prop #3607

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
1 participant
@youknowriad
Contributor

youknowriad commented Nov 22, 2017

This PR refactors the BlockList component slightly to extract the "Fixed Toolbar Feature Flag" as a prop. It's a layout specific config and shouldn't be accessed from state. Making it a prop allows this state to live separately in a potential future post-editor module.

This also fixes a small bug in the Ellipsis menu where the "Fix to block" checkmark was inverted.

Testing instructions

  • Toggle the "Fixed/Context Toolbar"
  • Check that it works as expected

@youknowriad youknowriad self-assigned this Nov 22, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 22, 2017

Codecov Report

Merging #3607 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
+ Coverage   36.93%   36.95%   +0.01%     
==========================================
  Files         268      268              
  Lines        6676     6673       -3     
  Branches     1203     1202       -1     
==========================================
  Hits         2466     2466              
+ Misses       3557     3555       -2     
+ Partials      653      652       -1
Impacted Files Coverage Δ
.../components/block-list/block-contextual-toolbar.js 0% <ø> (ø) ⬆️
editor/modes/visual-editor/index.js 0% <0%> (ø) ⬆️
editor/components/block-list/block.js 0.74% <0%> (ø) ⬆️
editor/components/block-list/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b4719...2c4e031. Read the comment docs.

codecov bot commented Nov 22, 2017

Codecov Report

Merging #3607 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
+ Coverage   36.93%   36.95%   +0.01%     
==========================================
  Files         268      268              
  Lines        6676     6673       -3     
  Branches     1203     1202       -1     
==========================================
  Hits         2466     2466              
+ Misses       3557     3555       -2     
+ Partials      653      652       -1
Impacted Files Coverage Δ
.../components/block-list/block-contextual-toolbar.js 0% <ø> (ø) ⬆️
editor/modes/visual-editor/index.js 0% <0%> (ø) ⬆️
editor/components/block-list/block.js 0.74% <0%> (ø) ⬆️
editor/components/block-list/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b4719...2c4e031. Read the comment docs.

@youknowriad youknowriad merged commit 5af0065 into master Nov 23, 2017

3 checks passed

codecov/project 36.95% (+0.01%) compared to 08b4719
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/extract-feature-flags branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment