New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: insertion point is missing #3613

Merged
merged 2 commits into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Nov 22, 2017

Description

This PR fixes the problem reported in issue #3599.
Where our blue line indicating where a block would be inserted was not appearing. Two bugs existed simultaneously, one wrong scss class name and missing props that would allow the correct dispatching of the actions to show the insert position.

How Has This Been Tested?

  1. Go to the inserter.
  2. Pass mouse over a block and see a blue line appears in the block inserting position.

Screenshots (jpeg or gifs if applicable):

image

@aduth

aduth approved these changes Nov 27, 2017

Looks good 👍

@jorgefilipecosta jorgefilipecosta merged commit a72924f into master Nov 27, 2017

3 checks passed

codecov/project 37.32% remains the same compared to 9864a60
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/Insertion-point-is-missing branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment