Ensure menus before map operation in Nav block #36355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
removed
the
Backport to WP Beta/RC
|
Size Change: +8 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
7 tasks
talldan
approved these changes
Nov 10, 2021
talldan
added
the
Backport to WP Beta/RC
getdave
force-pushed
the
fix/ensure-menus-before-map-operation
branch
from
6d82f7e
to
25bf151
Compare
|
Rebasin' then I'll merge this. |
adamziel
approved these changes
Nov 10, 2021
|
Cherry picked into the Gutenberg 11.9 release in: 885dc53 |
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential source of error in the Navigation block placeholder whereby the "existing menus" dropdown attempts to map over variables which are expected to be arrays but which may undefined.
This PR safeguards against this.
Note that
<MenuGroup>will not render anything if it doesn't have children which really helps us out here.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).