New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract TableOfContents as reusable component #3639

Merged
merged 1 commit into from Nov 24, 2017

Conversation

Projects
None yet
1 participant
@youknowriad
Contributor

youknowriad commented Nov 24, 2017

Extract a reusable TableOfContents to the editor/components folder.
Needed to be able to separate the edit-post and editor module

Testing instructions

  • Check that the "info" button style works (header toolbar)

@youknowriad youknowriad self-assigned this Nov 24, 2017

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Nov 24, 2017

Contributor

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

Contributor

youknowriad commented Nov 24, 2017

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 24, 2017

Codecov Report

Merging #3639 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
+ Coverage    36.8%   36.85%   +0.04%     
==========================================
  Files         268      268              
  Lines        6649     6640       -9     
  Branches     1201     1201              
==========================================
  Hits         2447     2447              
+ Misses       3550     3541       -9     
  Partials      652      652
Impacted Files Coverage Δ
editor/components/table-of-contents/index.js 0% <ø> (ø)
editor/edit-post/header/header-toolbar/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b19f4f...5d0cbdd. Read the comment docs.

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3639 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
+ Coverage    36.8%   36.85%   +0.04%     
==========================================
  Files         268      268              
  Lines        6649     6640       -9     
  Branches     1201     1201              
==========================================
  Hits         2447     2447              
+ Misses       3550     3541       -9     
  Partials      652      652
Impacted Files Coverage Δ
editor/components/table-of-contents/index.js 0% <ø> (ø)
editor/edit-post/header/header-toolbar/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b19f4f...5d0cbdd. Read the comment docs.

@youknowriad youknowriad merged commit b81cdf6 into master Nov 24, 2017

3 checks passed

codecov/project 36.85% (+0.04%) compared to 7b19f4f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/extract-table-of-contents branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment