New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract Reusable PostPublishWithDropdown component #3642

Merged
merged 1 commit into from Nov 24, 2017

Conversation

Projects
None yet
1 participant
@youknowriad
Contributor

youknowriad commented Nov 24, 2017

Extract a reusable PostPublishWithDropdown component to the editor/components folder.
Needed to be able to separate the edit-post and editor module

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

Testing instructions

  • Click the publish dropdown component, it should open as expected.

@youknowriad youknowriad self-assigned this Nov 24, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 24, 2017

Codecov Report

Merging #3642 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
+ Coverage   36.81%   36.87%   +0.06%     
==========================================
  Files         271      271              
  Lines        6647     6636      -11     
  Branches     1202     1202              
==========================================
  Hits         2447     2447              
+ Misses       3547     3536      -11     
  Partials      653      653
Impacted Files Coverage Δ
editor/components/post-publish-dropdown/index.js 0% <ø> (ø)
...tor/components/post-publish-with-dropdown/index.js 0% <0%> (ø)
editor/edit-post/header/index.js 0% <0%> (ø) ⬆️
editor/edit-post/header/header-toolbar/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5837d...3fbcc16. Read the comment docs.

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3642 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
+ Coverage   36.81%   36.87%   +0.06%     
==========================================
  Files         271      271              
  Lines        6647     6636      -11     
  Branches     1202     1202              
==========================================
  Hits         2447     2447              
+ Misses       3547     3536      -11     
  Partials      653      653
Impacted Files Coverage Δ
editor/components/post-publish-dropdown/index.js 0% <ø> (ø)
...tor/components/post-publish-with-dropdown/index.js 0% <0%> (ø)
editor/edit-post/header/index.js 0% <0%> (ø) ⬆️
editor/edit-post/header/header-toolbar/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5837d...3fbcc16. Read the comment docs.

@youknowriad youknowriad merged commit 1856f8c into master Nov 24, 2017

3 checks passed

codecov/project 36.87% (+0.06%) compared to bc5837d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/extract-publish-with-dropdown branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment