New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract PostTrashCheck reusable component #3646

Merged
merged 1 commit into from Nov 24, 2017

Conversation

Projects
None yet
1 participant
@youknowriad
Contributor

youknowriad commented Nov 24, 2017

Extract a reusable PostTrashCheck component to the editor/components folder.
Needed to be able to separate the edit-post and editor module

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

Testing instructions

  • Click the post trash link shows up when the post is not "new"

@youknowriad youknowriad self-assigned this Nov 24, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 24, 2017

Codecov Report

Merging #3646 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3646      +/-   ##
==========================================
+ Coverage    36.9%   36.92%   +0.02%     
==========================================
  Files         272      273       +1     
  Lines        6631     6627       -4     
  Branches     1201     1201              
==========================================
  Hits         2447     2447              
+ Misses       3532     3528       -4     
  Partials      652      652
Impacted Files Coverage Δ
editor/components/post-trash/check.js 0% <0%> (ø)
editor/edit-post/sidebar/post-trash/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51fbe3...cc03dcf. Read the comment docs.

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3646 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3646      +/-   ##
==========================================
+ Coverage    36.9%   36.92%   +0.02%     
==========================================
  Files         272      273       +1     
  Lines        6631     6627       -4     
  Branches     1201     1201              
==========================================
  Hits         2447     2447              
+ Misses       3532     3528       -4     
  Partials      652      652
Impacted Files Coverage Δ
editor/components/post-trash/check.js 0% <0%> (ø)
editor/edit-post/sidebar/post-trash/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51fbe3...cc03dcf. Read the comment docs.

@youknowriad youknowriad merged commit 979aa2f into master Nov 24, 2017

3 checks passed

codecov/project 36.92% (+0.02%) compared to e51fbe3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/extract-post-trash-check branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment