New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Tweak the notices design and position #3671

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Nov 27, 2017

closes #3457

screen shot 2017-11-27 at 13 48 10

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Nov 27, 2017

Contributor

I dig it, I can get behind this.

The padding is a little tight around the text on the left:

screen shot 2017-11-27 at 14 03 53

Is this padding that's decided on by WordPress itself, or something we've rebuilt for Gutenberg? If the former, then it shouldn't be fixed, if the latter, then I'd make the padding match top right bottom and left of the text.

Contributor

jasmussen commented Nov 27, 2017

I dig it, I can get behind this.

The padding is a little tight around the text on the left:

screen shot 2017-11-27 at 14 03 53

Is this padding that's decided on by WordPress itself, or something we've rebuilt for Gutenberg? If the former, then it shouldn't be fixed, if the latter, then I'd make the padding match top right bottom and left of the text.

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Nov 27, 2017

Contributor

@jasmussen It's a custom padding, I adjusted it, let me know if it's better.

Contributor

youknowriad commented Nov 27, 2017

@jasmussen It's a custom padding, I adjusted it, let me know if it's better.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Nov 27, 2017

Contributor

I think this padding would work better:

.editor-layout .components-notice-list .notice {
    margin: 0 0 5px;
    padding: 6px 12px;
    min-height: 50px;
}

screen shot 2017-11-27 at 14 15 29

With that, 👍 👍 from me.

Contributor

jasmussen commented Nov 27, 2017

I think this padding would work better:

.editor-layout .components-notice-list .notice {
    margin: 0 0 5px;
    padding: 6px 12px;
    min-height: 50px;
}

screen shot 2017-11-27 at 14 15 29

With that, 👍 👍 from me.

@karmatosed

Great to see this, thanks!

@youknowriad youknowriad merged commit c575dd5 into master Nov 28, 2017

3 checks passed

codecov/project 37.32% remains the same compared to 9864a60
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/tweak-notices-position branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment