Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the typography support to group/row blocks #37456

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Add the typography support to group/row blocks #37456

merged 1 commit into from
Dec 17, 2021

Conversation

youknowriad
Copy link
Contributor

While working on a block theme, on several occasions I had the need to define the base font size, and typography settings for a whole section (sidebar, row...), I ended up duplicating the same config over multiple blocks.

This PR solves that by adding the different typography block supports to the group/row blocks.

Testing instructions

  • Try changing font sizes (or any typography setting) for a group of blocks.

@youknowriad youknowriad added [Feature] Blocks Overall functionality of blocks [Block] Group Affects the Group Block [Type] Feature New feature to highlight in changelogs. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Dec 16, 2021
@youknowriad youknowriad requested review from mtias, jasmussen and a team December 16, 2021 12:31
@youknowriad youknowriad self-assigned this Dec 16, 2021
@Andrew-Starr Andrew-Starr mentioned this pull request Dec 16, 2021
Closed
@talldan talldan linked an issue Dec 17, 2021 that may be closed by this pull request
Provide typography support at the Group block level. #37363
Closed
@youknowriad youknowriad merged commit 7303514 into trunk Dec 17, 2021
@youknowriad youknowriad deleted the add/typography-group branch December 17, 2021 10:01
@github-actions github-actions bot added this to the Gutenberg 12.3 milestone Dec 17, 2021
This was referenced Apr 14, 2022
Closed
Closed
@luisherranz luisherranz mentioned this pull request Jul 14, 2022
Closed
@t-hamano t-hamano mentioned this pull request Jul 29, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@carolinan carolinan carolinan approved these changes

@mtias mtias Awaiting requested review from mtias

@jasmussen jasmussen Awaiting requested review from jasmussen

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@youknowriad youknowriad

Labels
[Block] Group Affects the Group Block [Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Milestone
Gutenberg 12.3
Development

Successfully merging this pull request may close these issues.

Provide typography support at the Group block level.
3 participants
@youknowriad @aristath @carolinan