E2E: Fix flakey gallery and template e2e specs #38342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2022 16:06
…allery to see if that fixes issue with gallery caption test
glendaviesnz
added
[Block] Gallery
glendaviesnz
requested review from
ajitbohra,
mkevins,
nerrad and
ntwb
as code owners
…ges in Gallery to see if that fixes issue with gallery caption test" This reverts commit 483f581.
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
glendaviesnz
changed the title
glendaviesnz
changed the title
|
Thanks @glendaviesnz I ran each test 5 times locally. All passed without complaint. Trunk also passes locally for me 😄 but I guess the CLI is the true test. Given that we're in a sea of green, I think it's good to go.
|
ramonjd
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test for gallery caption sometimes fails due to timing differences with the newly uploaded file getting the focus before the caption is edited. This PR makes sure the Gallery block is selected before trying to edit the caption
Testing Instructions
PUPPETEER_HEADLESS="false" npm run test-e2e specs/editor/blocks/gallery.test.jspasses locally and that the e2e tests pass in CI