Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix keyboard trap in the form token component and improve accessibility #3866
This PR tries to partially address #1339 fixing a couple issues, specifically:
Re: the keyboard trap, what happens right now is that when there is one (or multiple) token added, tabbing backwards from the field:
To fix this, I'm making
If desired, styling improvements can go in a separate issue.
Testing with NVDA, the aria-expanded state is announced correctly:
Agreed, this is not the simplest component we have :). It's also hard to get right (several variations depending on props...) which explains a bit why it's so complex.
@youknowriad thanks! I'm seeing a small glitch where the caret is not visible in the input field, especially on Firefox but this happens also on master so I'm going to merge anyways. To reproduce:
Will report also on #1339.