New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post schedule: remove duplicated button-link styles #3890

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
3 participants
@Soean
Member

Soean commented Dec 9, 2017

Description

The post schedule .button-link styles were overridden by .wp-core-ui .button-link.
This PR removes the duplicated .button-link styles and makes it possible for .editor-post-schedule__toggle.button-link to override the global .wp-core-ui .button-link.

Screenshots (jpeg or gifs if applicable):

Before:
before

After:
after

Remove styles, which are already set by `.wp-core-ui .button-link`.
Add .wp-core-ui to override the global .button-link style.
@youknowriad

Nice 👍

text-align: right;
&:focus {
outline: none;

This comment has been minimized.

@aduth

aduth Dec 11, 2017

Member

Noting that this style does not exist on the base .button-link, but also that it's questionable we'd want it.

@aduth

aduth Dec 11, 2017

Member

Noting that this style does not exist on the base .button-link, but also that it's questionable we'd want it.

@youknowriad youknowriad merged commit 220d48d into master Dec 13, 2017

3 checks passed

codecov/project 38.2% remains the same compared to 1501844
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/post-schedule-toggle branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment