New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Editable.getSettings() #3892

Merged
merged 1 commit into from Dec 23, 2017

Conversation

Projects
None yet
2 participants
@BE-Webdesign
Contributor

BE-Webdesign commented Dec 9, 2017

Add tests for Editable.getSettings()

Show outdated Hide outdated blocks/editable/test/index.js Outdated
Show outdated Hide outdated blocks/editable/test/index.js Outdated
@gziolo

gziolo approved these changes Dec 15, 2017

I left some minor comments, which aren't blockers. This looks good. Again, this tests a private method, which isn't ideal. Let's move on with this anyway :)

@BE-Webdesign BE-Webdesign merged commit 06317d7 into master Dec 23, 2017

3 checks passed

codecov/project 39.13% (+0.01%) compared to 204c6b8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@BE-Webdesign BE-Webdesign deleted the add/test/blocks/editable-2 branch Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment