New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index rebase #3930

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@vladanost
Contributor

vladanost commented Dec 12, 2017

Description

z-index values rebased in build styles in Gutenberg 1.9.0

The issue seems to be a regression from version 1.8.1 caused by introduction of webpack-rtl-plugin. This plugin is using cssnano which has a default option set to rebase z-index values http://cssnano.co/optimisations/zindex/
This regression can be seen when comparing build styles from last 2 versions
https://plugins.trac.wordpress.org/browser/gutenberg/tags/1.9.0/components/build/style.css
https://plugins.trac.wordpress.org/browser/gutenberg/tags/1.8.1/components/build/style.css
Search for .components-popover{position:fixed;z-index to see the difference.
In 1.8.1 z-index is 1000000 and in 1.9.0 it is rebased to 6.

webpack-rtl-plugin accepts configuration for minifying which are passed to cssnano as options. I'm setting the safe:true which will disable z-index rebase.

The effects of z-index rebase can be seen here:
screen shot 2017-12-09 at 18 14 38
screen shot 2017-12-09 at 18 22 44

Also reported here #3897

@youknowriad

Nice investigation work here. Thanks for the fix 👍

@youknowriad youknowriad merged commit 5648a77 into WordPress:master Dec 12, 2017

2 checks passed

codecov/project 38.37% remains the same compared to 75bb276
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde added this to the 1.9.1 milestone Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment