UnitControl: forward onBlur prop as expected
#39589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
ciampo
requested review from
mirka,
stokesman,
andrewserong and
aaronrobertshaw
and removed request for
ajitbohra
There was a problem hiding this comment.
Thanks for this fix @ciampo 👍
The onBlur prop gets called when I would expect it to. Personally, I prefer this PR's option over the alternatives listed in the description.
I had one question regarding the calling of mayUpdateUnit within handleOnBlur and left that as an inline comment.
Should we also document the onBlur prop in the README.md?
ciampo
changed the title
UnitControl: actually call onBlur prop UnitControl: forward onBlur prop as expected
stokesman
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
This looks good and tests well for me. I agree the chosen approach is better than the alternatives listed in the description. I think it'd be good to move forward with this approach for now.
I also think it warrants a follow up about consistency with our other composite components. For instance, one of the first things I thought to check when reviewing this was how it's handled in RangeControl. There, focus and blur are only forwarded from the range input and not the number input. So that one feels a bit lacking as well.
ciampo
force-pushed
the
fix/unit-control-call-onblur-before-onmounting
branch
from
fc61272
to
76d95c8
Compare
7 tasks
|
Thank you both for validating the current approach for when to fire the I went ahead and:
I replied to that comment, but I'll wait for @aaronrobertshaw's reply to make sure that we're on the same page.
That's a great point. I've opened #39615 to start keeping track of it |
|
Size Change: +2.41 kB (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make the
UnitControlcomponent call theonBlurprop when either the quantity or unit inputs fire theblurevent.Why?
While working on #39522, I realised that
UnitControldoesn't forward theonBlurprop, despite declaring it in its types.How?
The current approach is to call the
onBlurprop when either the underlying quantityinputor the unitselectlose focus.Alternative approaches would be:
onBlurprop fromUnitControl's typesblur-related callbacks, something likeonQuantityBlurandonUnitBlurTesting Instructions
1. Apply this patch
UnitControls Storybook exampleonBlurcallback gets fired when iteracting with the quantityinputand the unitselect