Migrate editor package isPublishSidebarEnabled to preferences store
#39707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
18 tasks
|
Size Change: -11 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
talldan
requested review from
nerrad,
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
There was a problem hiding this comment.
Nice work on all these migration PRs @talldan! The code change looks good to me visually, but for some reason the publish setting didn't appear to be preserved for me when I switched from trunk to this branch. I had it switched off, but after changing branches, it defaulted back to on:
The steps I took:
- Switched to
trunk, cleared local storage - Created a new post, ensured the setting defaults to enabled
- Published the post
- Created a new post, set the pre-publish setting to disabled
- Published the post
- Closed the window
- Switched branch
- Created a new post, the pre-publish setting appears to default to
on - Toggling the setting thereafter appeared to work correctly
Apologies if I missed a step during testing!
Thanks for testing. I see that too, it seems to only happen on a newer version of |
talldan
force-pushed
the
migrate/editor-package-to-preferences-store
branch
from
c5a81e3
to
0e9c7b4
Compare
|
@andrewserong I see what it is. The migration function was ignoring a Not sure how I didn't notice it in my own testing, maybe I refreshed the page too quickly. Thanks for catching it. |
andrewserong
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Great catch @talldan, that's testing nicely now! 🎉
This LGTM — and I assume since the public API remains the same (all the selectors are still available, it's just that internally they now dispatch to a different store), we don't need to flag the change in the packages' changelogs?
Good question. Given the API is still the same I think it's ok not to mention anything. It's just an internal change. I may come back later and deprecate some of the selectors and actions for the post editor, at which point I'll mention it in the changelog. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #31965
What?
Migrates the editor package's
isPublishSidebarEnabledpreference to the preferences store.Why?
As outlined in #31965, the goal is to move persisted data out of our various stores to a centralized preferences store.
How?
This change is very straightforward, as this preference is just a single value, the changes are:
editorpackage's preferences reducer and related code has been removedTesting Instructions
trunkfirst, open the post editor's preferences modal and turn off 'Include pre-publish checklist'.