Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing Flow: 'Down' key at bottom creates new paragraph #3973

Merged
merged 4 commits into from Dec 14, 2017
Merged

Writing Flow: 'Down' key at bottom creates new paragraph #3973

merged 4 commits into from Dec 14, 2017

Commits on Dec 13, 2017

  1. Writing Flow: 'Down' key at bottom creates new paragraph

    @mcsf
    mcsf committed Dec 13, 2017
    Copy the full SHA
    198ad60 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. Refactor by adding appendDefaultBlock action

    @mcsf
    mcsf committed Dec 14, 2017
    Copy the full SHA
    9d31cfb View commit details
    Browse the repository at this point in the history

  2. WritingFlow: 'down' appends new block after any non-empty block 

    Fixes the following issue introduced by the parent commits:

1. Add a Quote block.
2. Fill out quote but not citation.
3. Keeping pressing ↓, hoping to move into an empty appendage, but
   nothing happens.

Also correctly account for block-level-only tabbables, e.g. Image.
    @mcsf
    mcsf committed Dec 14, 2017
    Copy the full SHA
    6157d13 View commit details
    Browse the repository at this point in the history

  3. BlockListBlock: Expose className constant

    @mcsf
    mcsf committed Dec 14, 2017
    Copy the full SHA
    9894675 View commit details
    Browse the repository at this point in the history