Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make the block settings menu item dynamic #3982
This PR tries to improve the interaction with the "Settings" menu item in the blocks "ellipsis" menu as detailed in #3340 (comment)
TODO: add a
It's a first try to test if the new interaction makes sense, can be improved later.
Basically the item label and action are "dynamic" meaning they change based on the sidebar tab state:
Also, renames the label (and tooltip) for the block ellipsis menu: I've opted for "More options", inspired by a similar control in Gmail > compose:
Note: when a control uses
would sound a bit weird. Note that the similar control in Gmail uses aria-expanded and doesn't change the label.
Also renames the sidebar ARIA region to