New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeds: Detect focus on embed sandbox #4011

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
1 participant
@aduth
Member

aduth commented Dec 14, 2017

This pull request seeks to improve the behavior of focusing embed blocks, allowing block selection by clicking on the embed.

Implementation notes:

Detecting click events on iframe is not normally possible, but this uses a technique to detect blur from the host window and whether at the point of blur the active element is the iframe, inferring that this implies that the iframe has received focus.

Testing instructions:

Verify that clicking an embed block selects it.

@aduth aduth added the Blocks label Dec 14, 2017

@aduth aduth merged commit ba4e71e into master Jan 4, 2018

3 checks passed

codecov/project 38.15% (-0.04%) compared to 79c3f34
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aduth aduth deleted the update/sandbox-focus branch Jan 4, 2018

@aduth aduth referenced this pull request Jan 4, 2018

Closed

Cannot delete embeds with backspace #4299

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment