New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jest v22.0.1 #4073

Merged
merged 4 commits into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@ntwb
Member

ntwb commented Dec 19, 2017

Description

• Upgrades Jest to v22.0.1 https://facebook.github.io/jest/blog/2017/12/18/jest-22.html

• Commit fcf70aa updates a single Jest snapshot per Jest v22 Mock function improvements #

How Has This Been Tested?

Ran npm test

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ntwb ntwb added the Build Tooling label Dec 19, 2017

ntwb added some commits Dec 19, 2017

onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onClick={[MockFunction]}

This comment has been minimized.

@gziolo

gziolo Dec 19, 2017

Member

@sirreal You might like it, it is possible as of Jest 22.x to provide your own name to the mock, too. See: https://facebook.github.io/jest/blog/2017/12/18/jest-22.html#mock-function-improvements.

@gziolo

gziolo Dec 19, 2017

Member

@sirreal You might like it, it is possible as of Jest 22.x to provide your own name to the mock, too. See: https://facebook.github.io/jest/blog/2017/12/18/jest-22.html#mock-function-improvements.

@gziolo

gziolo approved these changes Dec 19, 2017

That was fast 💯

Diff for package-lock.json seems a bit big, but it looks reasonable.

@gziolo gziolo merged commit d8db53a into master Dec 19, 2017

3 checks passed

codecov/project 38.72% remains the same compared to 6a287a4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gziolo gziolo deleted the update/jest branch Dec 19, 2017

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Dec 19, 2017

Member

Diff for package-lock.json seems a bit big, but it looks reasonable.

@gziolo It looked reasonable to me, I'm creating a new PR to recreate the package-lock.json to see how it looks with the latest Node.js and npm

Member

ntwb commented Dec 19, 2017

Diff for package-lock.json seems a bit big, but it looks reasonable.

@gziolo It looked reasonable to me, I'm creating a new PR to recreate the package-lock.json to see how it looks with the latest Node.js and npm

@ntwb ntwb referenced this pull request Dec 19, 2017

Merged

Recreate `package-lock.json` using Node.js 8.9.3 & npm 5.6.0 #4075

3 of 3 tasks complete

@sirreal sirreal referenced this pull request Dec 19, 2017

Merged

Deps: Update Jest to 22 #20943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment