New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selectors and actions files to the store folder #4085

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Dec 19, 2017

This does nothing aside moving the selectors and actions to the store folder. This gives the editor module a nice folder structure.

I'd appreciate a quick review/merge to avoid rebases.

@youknowriad youknowriad self-assigned this Dec 19, 2017

@youknowriad youknowriad requested review from gziolo and aduth Dec 19, 2017

@aduth

aduth approved these changes Dec 19, 2017

Might run into some issues with stale branches merging based on the old paths, but I assume we can fix these as the issues occur.

@@ -1,63 +0,0 @@
/**

This comment has been minimized.

@aduth

aduth Dec 19, 2017

Member

I guess this was a dead file?

@aduth

aduth Dec 19, 2017

Member

I guess this was a dead file?

This comment has been minimized.

@youknowriad

youknowriad Dec 19, 2017

Contributor

Yep 👍

@youknowriad

youknowriad Dec 19, 2017

Contributor

Yep 👍

@youknowriad youknowriad merged commit 0257138 into master Dec 19, 2017

3 checks passed

codecov/project 38.9% (+0.1%) compared to e133c87
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/move-actions-selectors branch Dec 19, 2017

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Dec 19, 2017

Member

Nice 👍

Member

gziolo commented Dec 19, 2017

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment