New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 column inserter #4095

Merged
merged 4 commits into from Dec 20, 2017

Conversation

Projects
None yet
3 participants
@karmatosed
Member

karmatosed commented Dec 19, 2017

This is a suggestion for #4080. It increases the 2 columns to 3 for the inserter.

Tammie Lister
3 column inserter
This is a suggestion for #4080. It increases the 2 columns to 3 for the inserter.

@karmatosed karmatosed requested a review from jasmussen Dec 19, 2017

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Dec 20, 2017

Contributor

Nice, I dig this. Though it's a bit cramped when it's just 300px wide:

screen shot 2017-12-20 at 08 43 44

The mobile safe area is 360px. If we make it 350px wide, it'll be more relaxed:

screen shot 2017-12-20 at 08 43 25

What do you think?

Contributor

jasmussen commented Dec 20, 2017

Nice, I dig this. Though it's a bit cramped when it's just 300px wide:

screen shot 2017-12-20 at 08 43 44

The mobile safe area is 360px. If we make it 350px wide, it'll be more relaxed:

screen shot 2017-12-20 at 08 43 25

What do you think?

Tammie Lister added some commits Dec 20, 2017

Tammie Lister
Widens the inserter
Adds in a wider inserter.
Tammie Lister
@karmatosed

This comment has been minimized.

Show comment
Hide comment
@karmatosed

karmatosed Dec 20, 2017

Member

I have now added in the titles and also widened the block:

2017-12-20 at 10 44

Member

karmatosed commented Dec 20, 2017

I have now added in the titles and also widened the block:

2017-12-20 at 10 44

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Dec 20, 2017

Contributor

Nice! 👍 👍

Contributor

jasmussen commented Dec 20, 2017

Nice! 👍 👍

Tammie Lister
Move title to center again
The left align wasn't working so lets move border and center align.
@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Dec 20, 2017

Contributor

Hey I like it, what if the titles had a border-top as well

screen shot 2017-12-20 at 17 04 28

Contributor

youknowriad commented Dec 20, 2017

Hey I like it, what if the titles had a border-top as well

screen shot 2017-12-20 at 17 04 28

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Dec 20, 2017

Contributor

We tried the top border in the past, but then the topmost group would "stack" the borders. I think we tried some first-child magic to address that, but ran into woes. Not sure.

Contributor

jasmussen commented Dec 20, 2017

We tried the top border in the past, but then the topmost group would "stack" the borders. I think we tried some first-child magic to address that, but ran into woes. Not sure.

@karmatosed

This comment has been minimized.

Show comment
Hide comment
@karmatosed

karmatosed Dec 20, 2017

Member

For now let's get in the 1 border and pondering a 2. If we can find a good option for it, I like the clarity of 2 :)

Member

karmatosed commented Dec 20, 2017

For now let's get in the 1 border and pondering a 2. If we can find a good option for it, I like the clarity of 2 :)

@karmatosed karmatosed merged commit 5b85f85 into master Dec 20, 2017

3 checks passed

codecov/project 39.11% (+0.16%) compared to 64ac510
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@karmatosed karmatosed deleted the try/three-column-inserter branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment