Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable comment feed links for block themes #41195

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

aristath
Copy link
Member

What?

This PR disables the comment-feed links for block themes.

Why?

Comment feed links trigger a whole lot of crawling bots to hit them, and then they spiral down to get individual comments. This makes absolutely no sense, causes a ton of additional requests to servers, increases hosting costs and carbon emissions for something that is not needed in 99.9999999% of the cases. If a site really needs them, they can always use the WP filter to enable them.

Comment feeds should be opt-in, not enabled by default.
Changing things for classic themes may be questionable, but at least we can do what's right for block themes.
Hopefully, in a few years when block themes are the norm, we will save a lot of unnecessary requests.

@aristath aristath requested a review from gziolo May 20, 2022 10:36
@aristath aristath added the [Type] Performance Related to performance efforts label May 20, 2022
@aristath aristath force-pushed the try/disable-comment-feed-link-in-block-themes branch from 9a274ae to d060849 Compare September 25, 2023 07:39
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/general-template.php
❔ lib/load.php

Copy link
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this change. This is feel like a breaking change. Let's break a trac ticket and discuss this there. But I am against disabling functionality we have no idea if it is being used or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants