New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transforms between Heading & Cover Image #4129

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@mcsf
Contributor

mcsf commented Dec 21, 2017

Description

Fixes #4003

How Has This Been Tested?

Screenshots (jpeg or gifs if applicable):

gutenberg-heading-cover-image-transform

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mcsf mcsf added the Blocks label Dec 21, 2017

@mcsf mcsf requested review from karmatosed and jorgefilipecosta Dec 21, 2017

@jorgefilipecosta

jorgefilipecosta approved these changes Dec 21, 2017 edited

Nice work 👍 I did some tests and everything worked as I expected. I left a minor comment regarding the styles other than it looks totally good.

Show outdated Hide outdated blocks/library/cover-image/style.scss

@mcsf mcsf merged commit 99f5f1d into master Dec 22, 2017

3 checks passed

codecov/project 39.17% (+0.09%) compared to 5c92e3d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mcsf mcsf deleted the add/heading-cover-image-transforms branch Dec 22, 2017

@mcsf mcsf referenced this pull request Jan 5, 2018

Merged

Cover Image: Fix style regression in textual placeholder #4326

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment