New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block toolbar by the block always on mobile #4131

Merged
merged 4 commits into from Jan 4, 2018

Conversation

Projects
None yet
3 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Dec 21, 2017

Description

This PR aims to fix #4079.
It disables the UI to change fixedToolbar on mobile and adds a new selector hasFixedToolbar to verify if the toolbar is fixed or not (on mobile it is never fixed).

How Has This Been Tested?

Enable fixedToolbar feature resizes to mobile see the feature is disabled and the UI to enable it is not present.
Enable fixedToolbar toolbar feature on a desktop resolution, reload and verify the feature is still enabled, close the window, resize to mobile, open Gutenberg on mobile resolution and see the feature is disabled.
cc: @karmatosed

@youknowriad

I think we probably have some styles we could delete (mobile styles for the fixed toolbar) but probably not easy to isolate.

This looks good to me, might be good to get a design approval as well.

@karmatosed karmatosed self-requested a review Jan 4, 2018

@karmatosed

Looks good to me, thanks.

jorgefilipecosta added some commits Dec 21, 2017

Replace all usages of isFeatureActive( state, 'fixedToolbar' ) with t…
…he new hasFixedToolbar selector.

The hasFixedToolbar selector besides taking in consideration if feature is active or not also takes in consideration that in mobile the feature should always be disabled.

@jorgefilipecosta jorgefilipecosta merged commit 91f71ef into master Jan 4, 2018

3 checks passed

codecov/project 39.21% (+0.01%) compared to d01a464
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the update/make-block-toolbar-by-the-block-on-mobile branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment